FIX : error in str replacing with raw str and replacing MultiThreader (ITK4) by MultiThreaderBase (ITK>=5) - #93
Open
Jules-GP wants to merge 2 commits into
Open
FIX : error in str replacing with raw str and replacing MultiThreader (ITK4) by MultiThreaderBase (ITK>=5) #93Jules-GP wants to merge 2 commits into
Jules-GP wants to merge 2 commits into
Conversation
…quence : dont use \ in normal strings
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates threading configuration in the test driver to use ITK’s newer threading API, and fixes Python string literals to avoid escape-sequence issues in UI warning titles.
Changes:
- Replace
itk::MultiThreaderusage withitk::MultiThreaderBaseand update the corresponding include. - Convert warning window titles in
ShapeAnalysisModule.pyto raw string literals to avoid invalid escape-sequence warnings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Testing/itkTestMain.h | Switches test-driver threading configuration from MultiThreader to MultiThreaderBase. |
| Modules/Scripted/ShapeAnalysisModule/ShapeAnalysisModule.py | Updates warning dialog titles to use raw strings, preventing invalid escape warnings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.