Highlight variant differences - #2505
Open
andrpie wants to merge 2 commits into
Open
Conversation
Won't work for legacy dataset inputs!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #2086
I still need to test whether this works as intended!!
It doesn't feel like the cleanest way to do it, especially with legacy dataset names.
match_datasets_by_namealready finds the intersection of datasets used in the fits, but it returnsDataSetSpecrather thanDataSetInput(the former has no variant information). Perhaps it would be better to parse variant name intoDataSetSpec?