fix(bundle): Pin the brig a bundle carries - #5
Merged
Merged
Conversation
BRIG_VERSION defaulted to "latest", resolved at build time from brig's releases list, prereleases included. So a bundle tag did not decide its brig: rebuilding one later, or cutting one while a brig rc was newest, gave a different binary under the same bundle version. And on Linux this is the brig a user gets, since brig's install.sh installs the bundle's. It is pinned now, like every other component in the block, at v0.2.0, which is what v0.1.0-rc8 carries, so nothing changes today. The next bundle is cut by bumping it to the brig release it is for. "latest" still works for a local build. Signed-off-by: Anastassios Nanos <ananos@nofire.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-bundle.shfetched brig atlatest, which includes prereleases. A bundletherefore carried whatever brig release was newest when it was built, and on
Linux that brig is the one a user gets. It was the only component not pinned.
Changes
BRIG_VERSIONdefaults tov0.2.0, the brig the current bundle alreadycarries.
BRIG_VERSION=lateststill works for a local build.Why v0.2.0 and not v0.3.0
CI builds a full bundle on every PR, and that build downloads the brig release
the pin names.
v0.3.0is not tagged yet, so pinning it now would fail CIhere. The bump to
v0.3.0goes in with the bundle release cut for it, once thetag exists.
Tested
sh -nandshellcheck -s shoverbuild-bundle.sh. The CI bundle buildexercises the pinned fetch.
🤖 Generated with Claude Code