Skip to content

fix(install): Name the bundle in the install summary - #9

Merged
ananos merged 1 commit into
mainfrom
fix/install-summary-names-bundle
Sep 25, 2026
Merged

ananos merged 1 commit into
mainfrom
fix/install-summary-names-bundle

Conversation

@ananos

@ananos ananos commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Summary

The installer's summary ended with

[brig-install] brig v0.1.0-rc8 is installed (user)

where v0.1.0-rc8 is the bundle's release, not brig's. Installed through brig's
own install.sh, the next line then read

brig-install: installed brig v0.2.0 into the runtime at /home/<user>/.local/share/brig/data/bin

so one install reported two brig versions. This came up in a rootless user
install on Ubuntu 24.04, next to a brig-side fix for the same run's PATH advice
(brig-sh/brig#352).

Changes

Testing

tests/install-summary.sh runs install.sh as a user install on a minimal fake
bundle (BUNDLE_VERSION=v9.9.9, a brig and a stub setup), with stubs for the
host checks:

$ sh tests/install-summary.sh
ok - the summary names the bundle and its version

The same test against the previous install.sh:

$ sh tests/install-summary.sh
[brig-install] brig v9.9.9 is installed (user)
...
FAIL: the summary does not name the bundle

sh -n (dash) and shellcheck -s sh pass over install.sh,
build-bundle.sh, the three generated scripts and the test. All four open
bundle branches (#6, #7, #8 and this one) apply to main together without a
conflict, and the four tests pass on the result.

🤖 Generated with Claude Code

The summary ended with

  [brig-install] brig v0.1.0-rc8 is installed (user)

where v0.1.0-rc8 is the bundle's release, not brig's. Installed through
brig's own install.sh, the next line then read

  brig-install: installed brig v0.2.0 into the runtime at ...

so one install reported two brig versions.

The line now reads "the brig runtime bundle v0.1.0-rc8 is installed
(user)". brig's version stays where it is known: in pins.env, which
`brig-ctl version` prints.

tests/install-summary.sh runs install.sh as a user install on a minimal
fake bundle, with stubs for the host checks, and checks the summary.
Against the previous install.sh it fails: the summary says
"brig v9.9.9 is installed (user)".

Signed-off-by: Anastassios Nanos <ananos@nofire.ai>
@ananos
ananos force-pushed the fix/install-summary-names-bundle branch from 0920d88 to 0b6cce5 Compare September 25, 2026 22:48
@ananos
ananos marked this pull request as ready for review September 25, 2026 22:52
@ananos
ananos merged commit 718ec15 into main Sep 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant