fix(install): Name the bundle in the install summary - #9
Merged
Merged
Conversation
This was referenced Sep 25, 2026
The summary ended with [brig-install] brig v0.1.0-rc8 is installed (user) where v0.1.0-rc8 is the bundle's release, not brig's. Installed through brig's own install.sh, the next line then read brig-install: installed brig v0.2.0 into the runtime at ... so one install reported two brig versions. The line now reads "the brig runtime bundle v0.1.0-rc8 is installed (user)". brig's version stays where it is known: in pins.env, which `brig-ctl version` prints. tests/install-summary.sh runs install.sh as a user install on a minimal fake bundle, with stubs for the host checks, and checks the summary. Against the previous install.sh it fails: the summary says "brig v9.9.9 is installed (user)". Signed-off-by: Anastassios Nanos <ananos@nofire.ai>
ananos
force-pushed
the
fix/install-summary-names-bundle
branch
from
September 25, 2026 22:48
0920d88 to
0b6cce5
Compare
6 tasks
ananos
marked this pull request as ready for review
September 25, 2026 22:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The installer's summary ended with
where v0.1.0-rc8 is the bundle's release, not brig's. Installed through brig's
own
install.sh, the next line then readso one install reported two brig versions. This came up in a rootless user
install on Ubuntu 24.04, next to a brig-side fix for the same run's PATH advice
(brig-sh/brig#352).
Changes
the brig runtime bundle v0.1.0-rc8 is installed (user).brig's version stays in
pins.env, whichbrig-ctl versionprints.tests/install-summary.sh, run by theScript testsCI step (the same step asfix(rootless): Give each user a device grant of their own #6 and fix(bundle): Run brig-ctl's ctr inside the rootless namespace #8, word for word).
Testing
tests/install-summary.shrunsinstall.shas a user install on a minimal fakebundle (
BUNDLE_VERSION=v9.9.9, a brig and a stub setup), with stubs for thehost checks:
The same test against the previous
install.sh:sh -n(dash) andshellcheck -s shpass overinstall.sh,build-bundle.sh, the three generated scripts and the test. All four openbundle branches (#6, #7, #8 and this one) apply to
maintogether without aconflict, and the four tests pass on the result.
🤖 Generated with Claude Code