feat(rollout): add partial recovery benchmark telemetry - #3585
Draft
macandro96 wants to merge 6 commits into
Draft
feat(rollout): add partial recovery benchmark telemetry#3585macandro96 wants to merge 6 commits into
macandro96 wants to merge 6 commits into
Conversation
macandro96
force-pushed
the
amahishi/partial-rollout-telemetry
branch
from
August 11, 2026 22:36
023fd58 to
6cefbf4
Compare
macandro96
force-pushed
the
amahishi/partial-rollout-telemetry
branch
from
August 20, 2026 15:28
590ac41 to
af43edd
Compare
Signed-off-by: Anish Mahishi <amahishi@nvidia.com> (cherry picked from commit 52aa315)
Signed-off-by: Anish Mahishi <amahishi@nvidia.com> (cherry picked from commit 815f3d9)
Signed-off-by: Anish Mahishi <amahishi@nvidia.com> (cherry picked from commit 9853cf4)
Signed-off-by: Anish Mahishi <amahishi@nvidia.com> (cherry picked from commit 67f8278)
Signed-off-by: Anish Mahishi <amahishi@nvidia.com> (cherry picked from commit eafe0a5)
(cherry picked from commit af43edd)
macandro96
force-pushed
the
amahishi/partial-rollout-telemetry
branch
from
August 24, 2026 21:03
af43edd to
a7d417d
Compare
Contributor
Author
|
Will be superseded by #3925 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds fixed-cadence benchmark telemetry for partial-rollout checkpointing and recovery.
rollout_checkpointing.telemetry_interval_s, independent of checkpoint frequency.This layer is observational and does not change checkpoint or recovery semantics.
Stack
Configuration
For an A/B benchmark, keep
telemetry_interval_sidentical between baseline and checkpoint-enabled runs. Change only checkpoint enablement or frequency.Primary metrics
rollout/throughput/vllm_output_tokens_per_secondrollout/throughput/canonical_output_tokens_per_secondrollout/throughput/canonical_groups_per_secondtiming/rollout_checkpoint/tq_save_secondstiming/rollout_checkpoint/total_save_secondstiming/rollout_checkpoint/exclusive_hold_secondstiming/rollout_checkpoint/barrier_wait_secondsValidation