[26.04_linux-nvidia-bos] Backport devlink external flag exposition - #542
Closed
gobenji wants to merge 1 commit into
Closed
[26.04_linux-nvidia-bos] Backport devlink external flag exposition#542gobenji wants to merge 1 commit into
gobenji wants to merge 1 commit into
Conversation
BugLink: https://bugs.launchpad.net/bugs/2163274 The external flag is part of the PCI SF port attributes, but unlike the PCI PF and PCI VF flavours it was never filled into the port dump, so userspace could not query it directly. Reporting of the external flag was missed for SF ports. Hence, put DEVLINK_ATTR_PORT_EXTERNAL for the PCI SF flavour as well, matching what PCI PF and PCI VF ports already report. $ devlink port show pci/0033:01:00.0/163840 pci/0033:01:00.0/163840: type eth netdev eth1 flavour pcisf controller 1 pfnum 0 sfnum 77 external true splittable false Reviewed-by: Parav Pandit <parav@nvidia.com> Signed-off-by: Shay Drory <shayd@nvidia.com> Link: https://patch.msgid.link/20260803090012.257242-1-shayd@nvidia.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> (cherry picked from commit cb59bfd419d0c560b9f7273522f9a4799062aad5 linux-next) Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com> Acked-by: Adham Abdalla <adhama@nvidia.com> Acked-by: Aya Levin <ayal@nvidia.com>
Contributor
PR Validation ReportPatchscan ✅ No Missing FixesAll cherry-picked commits checked — no missing upstream fixes found. PR Lint ✅ All checks passedDetailsChecking 1 commits... Cherry-pick digest: ┌──────────────┬──────────────────────────────────────────────────────────────────┬────────────┬─────────┬───────────────────────────┐ │ Local │ Referenced upstream / Patch subject │ Patch-ID │ Subject │ SoB chain │ ├──────────────┼──────────────────────────────────────────────────────────────────┼────────────┼─────────┼───────────────────────────┤ │ 69f962ec2d84 │ devlink: expose external flag for pci sf ports │ match │ found │ ok, backporter: bpoirier │ └──────────────┴──────────────────────────────────────────────────────────────────┴────────────┴─────────┴───────────────────────────┘ Lint: all checks passed. |
Collaborator
|
No issues or concerns.
|
jamieNguyenNVIDIA
approved these changes
Aug 11, 2026
jamieNguyenNVIDIA
left a comment
jamieNguyenNVIDIA
left a comment
Collaborator
There was a problem hiding this comment.
Acked-by: Jamie Nguyen <jamien@nvidia.com>
Collaborator
|
Merged, closing PR. |
Collaborator
BaseOS Kernel ReviewSummaryNo issues found across the reviewed commits. Findings: no problems found Latest watcher review: open review Generated test plan: open test plan Kernel deb build: successful (download debs, 4 files) Head: This comment is maintained by nv-pr-bot. It is updated when the GitHub watcher publishes a newer review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport the following change to the linux-nvidia kernel:
cb59bfd419d0c devlink: Expose external flag for PCI SF ports (net-next)
This flag is needed by the mlnx-sf tool that is part of ofed's mlnx-tools package.
This PR is the 26.04_linux-nvidia-bos counterpart of #541
NVBug: https://nvbugspro.nvidia.com/bug/6579497
LP: https://bugs.launchpad.net/ubuntu/+source/linux-nvidia/+bug/2163274