tee: optee: Fix FF-A offset handling on 64 KiB pages

[mahantesh-nvidia]

FF-A memory objects use 4 KiB pages, but the kernel page size may be larger. On systems with 64 KiB pages, offsets beyond the first 4 KiB must be encoded in offs_low and offs_high instead of internal_offs.

Fixes: 4615e5a ("optee: add FF-A support")

[nirmoy]

BaseOS Kernel Review

Warning

⚠️ Review needs attention

The FF-A offset-handling comment states the wrong boundary: the alternate encoding is used at 4 KiB, not only above it.

Findings: Critical 0 · High 0 · Medium 0 · Low 1

🔍 Review artifacts

• 🟠 Boro review: 1 finding
• 🔵 Test plan: ready for validation

📦 Kernel deb builds — 🔴 0/2 passed

• 🔴 amd64: build report · failure log
• 🔴 arm64: build report · failure log

Note

Build reports and debs are retained for 10 days after the PR closes.

Review metadata

• Reviewed head: 56999ac8f9d7
• Overall status: attention needed
• Architectures: 0/2 successful

This comment is maintained by BaseOS Reviewer and updated when the GitHub watcher publishes a newer review.

[clsotog]

@mahantesh-nvidia
Please target to this kernel tree NVIDIA:26.04_linux-nvidia.
No need to target NVIDIA:24.04_linux-nvidia-7.0-next since the changes from 26.04_linux-nvidia will go to this one.

Can you put more information about this PR? Like which project is this for and any nvbug for reference?
Is this patch will be submitted upstream?

[mahantesh-nvidia]

@mahantesh-nvidia Please target to this kernel tree NVIDIA:26.04_linux-nvidia. No need to target NVIDIA:24.04_linux-nvidia-7.0-next since the changes from 26.04_linux-nvidia will go to this one.

Can you put more information about this PR? Like which project is this for and any nvbug for reference? Is this patch will be submitted upstream?

Ack, I will open a PR against 26.04_linux-nvidia branch.
Sure, I will put more information (project, nvbug etc..,) in the PR against 26.04_linux-nvidia branch.

This is basically for Bluefield-4 project where we are integrating OP-TEE OS as a secure partition running under Hafnium at SEL2.

Due to project deadlines and customer requests, prioritizing the submission here and soon will submit the patch for review to upstream as well.

[clsotog]

@mahantesh-nvidia Please target to this kernel tree NVIDIA:26.04_linux-nvidia. No need to target NVIDIA:24.04_linux-nvidia-7.0-next since the changes from 26.04_linux-nvidia will go to this one.
Can you put more information about this PR? Like which project is this for and any nvbug for reference? Is this patch will be submitted upstream?

Ack, I will open a PR against 26.04_linux-nvidia branch. Sure, I will put more information (project, nvbug etc..,) in the PR against 26.04_linux-nvidia branch.

This is basically for Bluefield-4 project where we are integrating OP-TEE OS as a secure partition running under Hafnium at SEL2.

Due to project deadlines and customer requests, prioritizing the submission here and soon will submit the patch for review to upstream as well.

For BF4, I will say the PR should target NVIDIA:26.04_linux-nvidia-bos. I do not think older systems are using BF4.

[mahantesh-nvidia]

@mahantesh-nvidia Please target to this kernel tree NVIDIA:26.04_linux-nvidia. No need to target NVIDIA:24.04_linux-nvidia-7.0-next since the changes from 26.04_linux-nvidia will go to this one.
Can you put more information about this PR? Like which project is this for and any nvbug for reference? Is this patch will be submitted upstream?

Ack, I will open a PR against 26.04_linux-nvidia branch. Sure, I will put more information (project, nvbug etc..,) in the PR against 26.04_linux-nvidia branch.
This is basically for Bluefield-4 project where we are integrating OP-TEE OS as a secure partition running under Hafnium at SEL2.
Due to project deadlines and customer requests, prioritizing the submission here and soon will submit the patch for review to upstream as well.

For BF4, I will say the PR should target NVIDIA:26.04_linux-nvidia-bos. I do not think older systems are using BF4.

Ack. I created the PR: #553