[26.04_linux-nvidia-bos] Backport perf vendor events arm64: Fix Tegra410 Olympus PMU events - #550
Closed
nvmochs wants to merge 2 commits into
Closed
Conversation
…fetcher metrics The L1D prefetcher metrics (l1d_cache_rw_miss_ratio, l1d_demand_accesses, etc.) were incorrectly assigned to MetricGroup "L1I_Prefetcher_Effectiveness" and vice versa. This causes 'perf stat --metric-group L1D_Prefetcher_Effectiveness' to display L1I metrics, which is misleading. Swap the MetricGroup assignments so L1D metrics are in the L1D group and L1I metrics are in the L1I group. Fixes: 86ff690 ("perf vendor events arm64: Add Tegra410 Olympus PMU events") Signed-off-by: Saurav Sachidanand <sauravsc@amazon.com> Reviewed-by: Besar Wicaksono <bwicaksono@nvidia.com> Reviewed-by: Ian Rogers <irogers@google.com> Signed-off-by: Namhyung Kim <namhyung@kernel.org> (cherry picked from commit 2d85e13c5526eee5f4d5670472a949f1489707ed linux-next) Signed-off-by: Matthew R. Ochs <mochs@nvidia.com>
The name and description for NVIDIA Tegra410 Olympus implementation-defined event 0x0197 incorrectly indicate a TXREQ limit between one quarter and one half. Correct them to describe a TXREQ limit below one half. Fixes: 86ff690 ("perf vendor events arm64: Add Tegra410 Olympus PMU events") Signed-off-by: Besar Wicaksono <bwicaksono@nvidia.com> Reviewed-by: Ian Rogers <irogers@google.com> Signed-off-by: Namhyung Kim <namhyung@kernel.org> (cherry picked from commit 9453bc6a69ef43755f1c28d5688cacdd69fa16bd linux-next) Signed-off-by: Matthew R. Ochs <mochs@nvidia.com>
Collaborator
BaseOS Kernel ReviewTip ✅ Review passedNo issues found across the reviewed commits. Findings: none 🔍 Review artifacts
📦 Kernel deb builds — 🔴 0/2 passed
Note Build reports and debs are retained for 10 days after the PR closes. Review metadata
This comment is maintained by BaseOS Reviewer and updated when the GitHub watcher publishes a newer review. |
Contributor
PR Validation ReportPatchscan ✅ No Missing FixesAll cherry-picked commits checked — no missing upstream fixes found. PR Lint ❌ Errors foundDetailsChecking 2 commits...
Cherry-pick digest:
E: d87b6e86a46f ("perf vendor events arm64: Fix Tegra410 O"): linux-next cherry-pick needs a public patch Link: trailer (patch.msgid.link, lore.kernel.org or patchwork.kernel.org); SHA 9453bc6a69ef is not resolvable
E: c842bca035dd ("perf vendor events arm64: fix swapped Me"): linux-next cherry-pick needs a public patch Link: trailer (patch.msgid.link, lore.kernel.org or patchwork.kernel.org); SHA 2d85e13c5526 is not resolvable
┌──────────────┬──────────────────────────────────────────────────────────────────┬────────────┬─────────┬───────────────────────────┐
│ Local │ Referenced upstream / Patch subject │ Patch-ID │ Subject │ SoB chain │
├──────────────┼──────────────────────────────────────────────────────────────────┼────────────┼─────────┼───────────────────────────┤
│ d87b6e86a46f │ 9453bc6a69ef │ ERROR │ ERROR │ ERROR │
├──────────────┼──────────────────────────────────────────────────────────────────┼────────────┼─────────┼───────────────────────────┤
│ c842bca035dd │ 2d85e13c5526 │ ERROR │ ERROR │ ERROR │
└──────────────┴──────────────────────────────────────────────────────────────────┴────────────┴─────────┴───────────────────────────┘
Lint results:
W: c842bca035dd ("perf vendor events arm64: fix swapped MetricGroup "): subject 84 chars (>72)
|
Collaborator
|
|
Collaborator
|
|
nirmoy
added
has_2_acks
and removed
help wanted
Collaborator
Author
|
Merged, closing PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small series adds a few fixes for the Tegra410 (Vera) perf PMU events.
LKML: https://lore.kernel.org/all/20260813170155.1156593-1-bwicaksono@nvidia.com/#r
The series is upstream (in linux-next) and expected in v7.4.
linux-next:
Tested with GLT: DGX-17750
LP: https://bugs.launchpad.net/ubuntu/+source/linux-nvidia-bos/+bug/2164783