tee: optee: Fix FF-A offset handling on 64 KiB pages

[mahantesh-nvidia]

FF-A memory objects use 4 KiB pages, but the kernel page size may be larger. On systems with 64 KiB pages, offsets beyond the first 4 KiB must be encoded in offs_low and offs_high instead of internal_offs.

Fixes: 4615e5a ("optee: add FF-A support")

[nirmoy]

BaseOS Kernel Review

Warning

⚠️ Review needs attention

The FF-A offset-handling comment contradicts the code at the 4 KiB boundary: alternate encoding is used when the offset equals 4 KiB, not only when it exceeds it.

Findings: Critical 0 · High 0 · Medium 0 · Low 1

🔍 Review artifacts

• 🟠 Boro review: 1 finding
• 🔵 Test plan: ready for validation

📦 Kernel deb builds — 🔴 0/2 passed

• 🔴 amd64: build report · failure log
• 🔴 arm64: build report · failure log

Note

Build reports and debs are retained for 10 days after the PR closes.

Review metadata

• Reviewed head: 2ec68c602102
• Overall status: attention needed
• Architectures: 0/2 successful

This comment is maintained by BaseOS Reviewer and updated when the GitHub watcher publishes a newer review.

[mahantesh-nvidia]

This patch is needed for Bluefield-4 product/project. This fix is part of an effort to integrate OP-TEE OS as a Secure Partition running under Hafnium (SEL2).

Link to Feature Request: (Redmine) https://redmine.mellanox.com/issues/4654738

Due to project deadlines and customer requests prioritizing the submission here and will soon submit the patch for upstream as well.

[github-actions]

PR Validation Report

Patchscan ✅ No Missing Fixes

All cherry-picked commits checked — no missing upstream fixes found.

PR Lint ❌ Errors found

Details

Checking 1 commits...

Cherry-pick digest:
┌──────────────┬──────────────────────────────────────────────────────────────────┬────────────┬─────────┬───────────────────────────┐
│ Local        │ Referenced upstream / Patch subject                              │ Patch-ID   │ Subject │ SoB chain                 │
├──────────────┼──────────────────────────────────────────────────────────────────┼────────────┼─────────┼───────────────────────────┤
│ 2ec68c602102 │ [SAUCE] tee: optee: fix ff-a offset handling on 64 kib pages     │ N/A        │ N/A     │ mahantes                  │
└──────────────┴──────────────────────────────────────────────────────────────────┴────────────┴─────────┴───────────────────────────┘

Lint results:
E: 2ec68c602102 ("tee: optee: Fix FF-A offset handling on 64 KiB pag"): not SAUCE/UBUNTU/Revert but has no upstream reference trailer (cherry picked from commit ... or backported from ...)

PR metadata:
W: PR title missing [<branch>] prefix: "tee: optee: Fix FF-A offset handling on 64 KiB pages"
E: PR targets 26.04_linux-nvidia but body has no https://bugs.launchpad.net/... link

[nvmochs]

This patch is needed for Bluefield-4 product/project. This fix is part of an effort to integrate OP-TEE OS as a Secure Partition running under Hafnium (SEL2).

Link to Feature Request: (Redmine) https://redmine.mellanox.com/issues/4654738

Due to project deadlines and customer requests prioritizing the submission here and will soon submit the patch for upstream as well.

@mahantesh-nvidia This is still targeting the wrong branch. Please target 26.04_linux-nvidia-bos.

Also, my preference would be for you to at least send this upstream and include the LKML link as a "backported from commit" tag in the patch for tracking.

Lastly, if this is to be taken as an out-of-tree patch, the patch needs to have a "NVIDIA: SAUCE: " tag prepended to the commit title.

See other commits on this branch as an example for both the backported and title tags.

[mahantesh-nvidia]

This patch is needed for Bluefield-4 product/project. This fix is part of an effort to integrate OP-TEE OS as a Secure Partition running under Hafnium (SEL2).
Link to Feature Request: (Redmine) https://redmine.mellanox.com/issues/4654738
Due to project deadlines and customer requests prioritizing the submission here and will soon submit the patch for upstream as well.

@mahantesh-nvidia This is still targeting the wrong branch. Please target 26.04_linux-nvidia-bos.

Also, my preference would be for you to at least send this upstream and include the LKML link as a "backported from commit" tag in the patch for tracking.

Lastly, if this is to be taken as an out-of-tree patch, the patch needs to have a "NVIDIA: SAUCE: " tag prepended to the commit title.

See other commits on this branch as an example for both the backported and title tags.

Ack. I created the PR against 26.04_linux-nvidia-bos here: #553
Yes, I'm planning to send this upstream. Thanks