change all references from 26.05 to 26.08 - #2574
Conversation
Greptile SummaryThis PR advances release, Helm, documentation, workflow, and compatibility references from 26.05 to 26.08 and adds an NVIDIA-hosted-endpoints service profile.
|
| Filename | Overview |
|---|---|
| .github/workflows/nrl-docs-nvidia-publish.yml | Retargets the deliberate, dry-run-first publishing workflow and latest metadata to 26.08 without restoring unsafe automatic triggers. |
| docs/publish/versions.json | Moves the latest documentation alias from 26.5.0 to 26.8.0 consistently with the workflow source branch. |
| nemo_retriever/src/nemo_retriever/service/client.py | Incorrectly relabels the historical job-scoped ingest API compatibility boundary as 26.08. |
| nemo_retriever/src/nemo_retriever/service/routers/ingest.py | Incorrectly reports that legacy ingest routes were removed in 26.08 rather than 26.05. |
| nemo_retriever/src/nemo_retriever/service/retriever-service-nvidia-endpoints.yaml | Adds an unpackaged profile that exposes unauthenticated MCP write operations when explicitly launched on a reachable host. |
| nemo_retriever/helm/values.yaml | Updates the default service image and release-specific comments to 26.8.0. |
Prompt To Fix All With AI
### Issue 1
nemo_retriever/src/nemo_retriever/service/client.py:171-173
**Incorrect ingest compatibility boundary**
When an SDK/service mismatch returns 404 or 410, this message says the job-scoped API was introduced in 26.08 and requires a 26.08+ service, but the API and legacy-route stubs entered through the 26.05 merge. This obscures the actual compatibility boundary and can prompt an unnecessary upgrade.
### Issue 2
nemo_retriever/src/nemo_retriever/service/retriever-service-nvidia-endpoints.yaml:219-225
**Unauthenticated MCP write operations**
If an operator launches this profile on a network-reachable host, it binds to `0.0.0.0` without bearer authentication while registering the `ingest_documents` MCP tool, allowing unauthenticated clients to create jobs, upload documents, and consume service or hosted-inference resources.
**How this was verified:** The profile's listener and auth settings were traced through MCP registration to the job-creation and document-upload endpoints.
### Issue 3
nemo_retriever/src/nemo_retriever/service/retriever-service-nvidia-endpoints.yaml:1
**Service profile omitted from wheel**
When a user installs the published package and selects this NVIDIA-endpoints profile, the file is unavailable because the service package-data manifest includes only `retriever-service.yaml`. Starting the service with the new profile path therefore fails unless the user separately obtains the source file.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "change all references from 26.05 to 26.0..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| "+ GET /v1/ingest/job/{job_id}/events) introduced in 26.08, " | ||
| "but the deployed nrl-service does not advertise that route. " | ||
| "Upgrade the chart/image to a 26.05+ build, or downgrade the " | ||
| "Upgrade the chart/image to a 26.08+ build, or downgrade the " |
There was a problem hiding this comment.
When an SDK/service mismatch returns 404 or 410, this message says the job-scoped API was introduced in 26.08 and requires a 26.08+ service, but the API and legacy-route stubs entered through the 26.05 merge. This obscures the actual compatibility boundary and can prompt an unnecessary upgrade.
Rule Used: When this PR changes user-facing code, configurati... (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: nemo_retriever/src/nemo_retriever/service/client.py
Line: 171-173
Comment:
**Incorrect ingest compatibility boundary**
When an SDK/service mismatch returns 404 or 410, this message says the job-scoped API was introduced in 26.08 and requires a 26.08+ service, but the API and legacy-route stubs entered through the 26.05 merge. This obscures the actual compatibility boundary and can prompt an unnecessary upgrade.
**Rule Used:** When this PR changes user-facing code, configurati... ([source](https://github.com/nvidia/nemo-retriever/blob/f2eed28a44b07956a9f1770ec5a469a9381baf27/.greptile/config.json))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| poll_interval_s: 2.0 | ||
|
|
||
| # Controls whether (and how widely) client-supplied PipelineSpec | ||
| # overrides are honored on a per-request basis. | ||
| # | ||
| # reject — every client override is rejected; YAML-only config. | ||
| # allow_list — only audited "shape" keys may be overridden |
There was a problem hiding this comment.
If an operator launches this profile on a network-reachable host, it binds to 0.0.0.0 without bearer authentication while registering the ingest_documents MCP tool, allowing unauthenticated clients to create jobs, upload documents, and consume service or hosted-inference resources.
How this was verified: The profile's listener and auth settings were traced through MCP registration to the job-creation and document-upload endpoints.
Prompt To Fix With AI
This is a comment left during a code review.
Path: nemo_retriever/src/nemo_retriever/service/retriever-service-nvidia-endpoints.yaml
Line: 219-225
Comment:
**Unauthenticated MCP write operations**
If an operator launches this profile on a network-reachable host, it binds to `0.0.0.0` without bearer authentication while registering the `ingest_documents` MCP tool, allowing unauthenticated clients to create jobs, upload documents, and consume service or hosted-inference resources.
**How this was verified:** The profile's listener and auth settings were traced through MCP registration to the job-creation and document-upload endpoints.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.| @@ -0,0 +1,254 @@ | |||
| # Retriever Service Mode — NVIDIA Inference API MCP profile | |||
There was a problem hiding this comment.
When a user installs the published package and selects this NVIDIA-endpoints profile, the file is unavailable because the service package-data manifest includes only retriever-service.yaml. Starting the service with the new profile path therefore fails unless the user separately obtains the source file.
Prompt To Fix With AI
This is a comment left during a code review.
Path: nemo_retriever/src/nemo_retriever/service/retriever-service-nvidia-endpoints.yaml
Line: 1
Comment:
**Service profile omitted from wheel**
When a user installs the published package and selects this NVIDIA-endpoints profile, the file is unavailable because the service package-data manifest includes only `retriever-service.yaml`. Starting the service with the new profile path therefore fails unless the user separately obtains the source file.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
4 participants
Description
Updates references to 26.08 from 26.05.
Checklist