Single grouped weight fixes#3225
Conversation
Signed-off-by: CarlosGomes98 <carlosmiguel.gomes@live.com.pt>
Signed-off-by: CarlosGomes98 <carlosmiguel.gomes@live.com.pt>
Signed-off-by: CarlosGomes98 <carlosmiguel.gomes@live.com.pt>
Greptile SummaryThis PR delivers three targeted correctness fixes to the
Confidence Score: 5/5Safe to merge — three targeted bug fixes each with an accompanying test; no existing API surfaces are changed. All three fixes are narrow and well-scoped. The high-precision init-val transfer is gated behind an all(value is not None) guard and raises an explicit error on inconsistency. The register_parameter override only fires for name == weight with both single_grouped_weight and delay_wgrad_compute set. The columnwise_usage stickiness is a monotonic flag that corrects a latent crash under CUDA graph replay. Tests cover all three scenarios including edge cases like meta-device shells and partial init-val state. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "[PyTorch] Preserve grouped MXFP8 columnw..." | Re-trigger Greptile |
|
/te-ci pytorch L1 |
Description
A few fixes to the single grouped weight implementation
12406c9 — Preserve grouped weight initialization metadata
99b3f37 — Mark late grouped weights for delayed wgrad
aa4e233 — Preserve grouped MXFP8 columnwise usage
See #3178 for the original PR.
PR #3224 is very relevant to this one, both are required fixes.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: