[CI] Minor CMake refactoring#3227
Draft
fheinecke wants to merge 3 commits into
Draft
Conversation
NCCL is now always required for all native build paths (due to a change sometime between v2.16 and main). This updates CMake to only search for the headers in a single place. This does not impact the NCCL EP dependency resolution. Signed-off-by: Fred Heinecke <fheinecke@nvidia.com>
This will now also search Python's site-packages, making it much easier
to pull in headers from `nvidia-nccl-cu{12,13}`.
Signed-off-by: Fred Heinecke <fheinecke@nvidia.com>
Previously this was provided every time the C++ or CUDA compiler was invoked for everything built by CMake, including compiler detection and compilation, instead of just when linking the TE library. Signed-off-by: Fred Heinecke <fheinecke@nvidia.com>
Collaborator
Author
|
/te-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a couple of minor CMake bugs, and slightly simplifies NCCL dependency resolution.
Type of change
Changes
Please list the changes introduced in this PR:
site-packages/nvidia/ncclis now searched for NCCL headers, making it easier to resolve them when installing NCCL vianvidia-nccl-cu{12,13}wheels.Checklist: