Skip to content

Fix nccl-extensions submodule name#3239

Merged
phu0ngng merged 1 commit into
NVIDIA:mainfrom
phu0ngng:nccl_ep_submodule
Jul 22, 2026
Merged

Fix nccl-extensions submodule name#3239
phu0ngng merged 1 commit into
NVIDIA:mainfrom
phu0ngng:nccl_ep_submodule

Conversation

@phu0ngng

Copy link
Copy Markdown
Collaborator

Description

Fix nccl-extensions submodule name.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
@phu0ngng
phu0ngng requested a review from denera July 22, 2026 20:51

@denera denera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes a leftover inconsistency introduced when the NCCL EP submodule was migrated to NVIDIA/nccl-extensions (#3222): the [submodule "…"] name in .gitmodules still read 3rdparty/nccl while the path and url already pointed to nccl-extensions.

  • Renames the submodule section header from 3rdparty/nccl to 3rdparty/nccl-extensions, making name, path, and URL consistent.
  • No other files in the repository referenced the old 3rdparty/nccl name, so this is a self-contained config correction with no side effects.

Confidence Score: 5/5

Safe to merge — the single-line change corrects a stale submodule name left over from the earlier migration, with no other files affected.

The only change is renaming the .gitmodules section header from 3rdparty/nccl to 3rdparty/nccl-extensions to match the already-correct path and url fields. No code logic, build scripts, or CI references use the old name, so there is no risk of regression.

No files require special attention.

Important Files Changed

Filename Overview
.gitmodules Renames submodule entry from 3rdparty/nccl to 3rdparty/nccl-extensions so the name matches the existing path and URL after the earlier migration to NVIDIA/nccl-extensions.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[".gitmodules before PR"] --> B["[submodule '3rdparty/nccl']\npath = 3rdparty/nccl-extensions\nurl = .../nccl-extensions.git"]
    B -- "name ≠ path (bug)" --> C["git submodule commands may fail\nto resolve by name"]

    D[".gitmodules after PR"] --> E["[submodule '3rdparty/nccl-extensions']\npath = 3rdparty/nccl-extensions\nurl = .../nccl-extensions.git"]
    E -- "name = path (fixed)" --> F["Submodule resolves correctly"]
Loading

Reviews (1): Last reviewed commit: "update nccl-ext submodule name" | Re-trigger Greptile

@phu0ngng
phu0ngng merged commit 8280f02 into NVIDIA:main Jul 22, 2026
10 of 14 checks passed
@phu0ngng
phu0ngng deleted the nccl_ep_submodule branch July 22, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants