[WIP] Address duplicate import issue found in pypi-installed cuda-core packages#2386
Draft
acosmicflamingo wants to merge 1 commit into
Draft
[WIP] Address duplicate import issue found in pypi-installed cuda-core packages#2386acosmicflamingo wants to merge 1 commit into
acosmicflamingo wants to merge 1 commit into
Conversation
Contributor
Contributor
Author
|
@mdboom when you have the chance, can you please run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2023
Right now, importing certain modules also imports a duplicate version where the cuda major version number resides in the name (e.g. importing
cuda.core.systemwill mean bothcuda.core.systemandcuda.core.cu13.systemare now insys.modules).It's also difficult to reproduce the problem locally. Running
pip install .was not giving me the file path I was expecting to write a failing test, which would allow me to assert that the solution I come up with actually works (assuming that the fix involves recompiling cython modules):I'm going to make it a draft for now so I can do the following:
If it turns out that the problem goes beyond relative imports in cython, then the fix might have to reside here.
Checklist