Skip to content

[Demos] Complete Waypoint V2 migration with Cam2V HUD - #572

Open
jmccaffrey-nv wants to merge 2 commits into
mainfrom
dev/jmccaffrey/waypoint-integ-v2
Open

[Demos] Complete Waypoint V2 migration with Cam2V HUD#572
jmccaffrey-nv wants to merge 2 commits into
mainfrom
dev/jmccaffrey/waypoint-integ-v2

Conversation

@jmccaffrey-nv

Copy link
Copy Markdown
Collaborator

Summary

PR #519 added V2 runtime support for Waypoint, but left the model in the legacy integrations/waypoint package. This completes the Waypoint portion of #479:

  • move the model, root configuration, and tests into integrations_v2/waypoint/{impl,tests} and remove the legacy tree
  • merge the split model/application distributions into flashdreams-waypoint
  • move the application binding to apps/cam2v and register cam2v-waypoint, matching LingBot World and HY-WorldPlay
  • reuse the shared Cam2V presentation/UI loop while retaining Waypoint's raw keyboard/mouse action adapter (Cam2V pose-matrix conditioning is not compatible with Waypoint controls)
  • parameterize the Cam2V HUD, show Waypoint's WASD/mouse/Shift/Space/R controls, and bracket held keys
  • bind R to rebuild the rollout cache, restore the seeded RNG, and immediately emit the starting image
  • update the lockfile, model docs, app usage, architecture diagrams, ADR, and validation record

Validation

  • pytest integrations_v2/waypoint/tests apps/cam2v/tests -m ci_cpu -q — 68 passed, 3 deselected
  • changed-file pre-commit suite — passed (Ruff, formatting, lock validation, package version sync, ty)
  • explicit ty check over Waypoint and Cam2V — passed
  • uv lock --check — passed
  • built flashdreams-waypoint wheel; verified model/app files, bundled controls, cam2v-waypoint entry point, and entry-point loading
  • sphinx-build -W -b html docs/source ... rendered the Waypoint page but the repository-wide build exits on the unchanged docs/source/api/integrations.rst:17 title-underline warning

CUDA and published-weight inference were not rerun because the migration only relocates model modules and changes application/UI boundaries. The prior CUDA, parity, long-rollout, and performance evidence remains in integrations_v2/waypoint/VALIDATION.md.

Signed-off-by: Jonathan McCaffrey <jmccaffrey@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR completes Waypoint’s migration into a single V2 package and connects it to the shared Cam2V presentation infrastructure.

  • Moves the model implementation, configuration, tests, and application binding under integrations_v2/waypoint.
  • Registers the consolidated flashdreams-waypoint package as cam2v-waypoint.
  • Adds a parameterized Cam2V HUD with Waypoint controls and deterministic rollout reset.
  • Restores on-demand presentation as Waypoint’s default and verifies exact finite-replay MP4 frame accounting.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previously reported finite-replay issue is fixed by the on-demand application default and an end-to-end MP4 frame-count test.

Important Files Changed

Filename Overview
integrations_v2/waypoint/apps/cam2v/adapter.py Defines the consolidated application binding and correctly defaults Waypoint to on-demand presentation for deterministic finite replay.
integrations_v2/waypoint/apps/cam2v/session.py Integrates the shared Cam2V HUD and adds deterministic R-key reset while retaining session-local cache, RNG, and control state.
apps/cam2v/cam2v/ui.py Generalizes the shared HUD into configurable control groups, instructions, and optional status widgets.
integrations_v2/waypoint/pyproject.toml Consolidates model and application packaging and registers the new cam2v-waypoint entry point.
integrations_v2/waypoint/tests/test_cam2v_app.py Covers package layout, reset behavior, HUD registration, session isolation, and exact seed-plus-action MP4 frame accounting.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    CLI[flashdreams-run-v2 cam2v-waypoint] --> Adapter[Waypoint Cam2V adapter]
    Adapter --> Session[Waypoint session]
    Session --> Model[Waypoint model loop]
    Session --> UI[Shared Cam2V HUD]
    Model --> Pipeline[Waypoint inference pipeline]
    Pipeline --> PM[Presentation manager]
    UI --> PM
    PM --> Output[WebRTC or MP4 output]
Loading

Reviews (2): Last reviewed commit: "fix: preserve Waypoint finite replay sem..." | Re-trigger Greptile

Comment thread integrations_v2/waypoint/apps/cam2v/adapter.py Outdated
Signed-off-by: Jonathan McCaffrey <jmccaffrey@nvidia.com>
@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Want your agent to iterate on Greptile's feedback? Try greploops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant