[Demos] Complete Waypoint V2 migration with Cam2V HUD - #572
Open
jmccaffrey-nv wants to merge 2 commits into
Open
[Demos] Complete Waypoint V2 migration with Cam2V HUD#572jmccaffrey-nv wants to merge 2 commits into
jmccaffrey-nv wants to merge 2 commits into
Conversation
Signed-off-by: Jonathan McCaffrey <jmccaffrey@nvidia.com>
Contributor
Greptile SummaryThe PR completes Waypoint’s migration into a single V2 package and connects it to the shared Cam2V presentation infrastructure.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported finite-replay issue is fixed by the on-demand application default and an end-to-end MP4 frame-count test. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
CLI[flashdreams-run-v2 cam2v-waypoint] --> Adapter[Waypoint Cam2V adapter]
Adapter --> Session[Waypoint session]
Session --> Model[Waypoint model loop]
Session --> UI[Shared Cam2V HUD]
Model --> Pipeline[Waypoint inference pipeline]
Pipeline --> PM[Presentation manager]
UI --> PM
PM --> Output[WebRTC or MP4 output]
Reviews (2): Last reviewed commit: "fix: preserve Waypoint finite replay sem..." | Re-trigger Greptile |
Signed-off-by: Jonathan McCaffrey <jmccaffrey@nvidia.com>
Contributor
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #519 added V2 runtime support for Waypoint, but left the model in the legacy
integrations/waypointpackage. This completes the Waypoint portion of #479:integrations_v2/waypoint/{impl,tests}and remove the legacy treeflashdreams-waypointapps/cam2vand registercam2v-waypoint, matching LingBot World and HY-WorldPlayRto rebuild the rollout cache, restore the seeded RNG, and immediately emit the starting imageValidation
pytest integrations_v2/waypoint/tests apps/cam2v/tests -m ci_cpu -q— 68 passed, 3 deselectedty checkover Waypoint and Cam2V — passeduv lock --check— passedflashdreams-waypointwheel; verified model/app files, bundled controls,cam2v-waypointentry point, and entry-point loadingsphinx-build -W -b html docs/source ...rendered the Waypoint page but the repository-wide build exits on the unchangeddocs/source/api/integrations.rst:17title-underline warningCUDA and published-weight inference were not rerun because the migration only relocates model modules and changes application/UI boundaries. The prior CUDA, parity, long-rollout, and performance evidence remains in
integrations_v2/waypoint/VALIDATION.md.