Add postprocessing to cam2v lingbot - #586
Merged
Merged
Conversation
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
gtong-nv
marked this pull request as ready for review
September 4, 2026 19:45
Contributor
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
Collaborator
Author
|
/ok to test 876eef1 |
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
Collaborator
Author
|
/ok to test c0e878b |
jmccaffrey-nv
requested changes
Sep 5, 2026
jmccaffrey-nv
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the thoughtful iteration here—the persistent stream, fixed presentation sizing, and comparison UI are a solid direction.
I’m requesting changes for two P1s:
- The new reset contract is not satisfied by every preset Cam2V advertises, so an RTX preset fails the reconnect/reset lifecycle required by #479.
- Once cadence is learned, the shared presentation clock ignores backlog, undoing the latency safeguard from #542 and changing Interactive Drive behavior despite that being out of scope.
The latest commit fixed the earlier pacing-test mismatch; the focused CPU suite now passes: 137 passed.
Two P2 follow-ups:
- For a stream beginning with exactly 8/16 frames, pass the real first chunk as AR0 (the encoder accepts it) instead of priming temporal/KV state with a discarded repeated-frame chunk; please add a non-constant-input test.
--postprocess-compiledefaults to false even though the preset default and Lingbot docs imply the compiled/prewarmed path is the default. Please preserve the preset unless the flag is explicitly supplied (for example,default=None), or align the docs and help text.
I did not duplicate the existing inline comment about raw-frame presentation sizing.
— assisted by GPT 5.6 Sol
Collaborator
Author
|
/ok to test 430caef |
gtong-nv
enabled auto-merge
September 9, 2026 03:29
Collaborator
Author
|
It measures the model.step(), but this is still not the end to end FPS that the user will perceive. Maybe we name it |
jmccaffrey-nv
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--postprocess-comparison-uito show the raw/upscaled and postprocessed streams side by side.