[Models] Add LongSANA Runtime V2 text-to-video pipeline - #591
[Models] Add LongSANA Runtime V2 text-to-video pipeline#591jmccaffrey-nv wants to merge 2 commits into
Conversation
Greptile SummaryThe PR adds a packaged Runtime V2 LongSANA 2B text-to-video integration with recurrent session-local attention state, model and scheduler implementations, shared Wan VAE decoding, application registration, validation tooling, tests, and operational documentation. Changes since the previous review:
Confidence Score: 5/5The PR appears safe to merge; the previously outstanding rollout-limit defect is fixed and no new actionable failures were found. The rollout limit is now validated before model setup and again when a cache starts a block, while active frame counts are session-local and correctly drive noise generation. The earlier shared-index thread was manually resolved without explanation; the current implementation independently removes that shared mutable state. No blocking or non-blocking new findings remain. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
P[Prompt] --> E[Gemma / CHI prompt encoder]
E --> C[Session-local conditioning and recurrent cache]
C --> D[LongSANA recurrent DiT]
D --> S[Four-step flow scheduler]
S --> F[Clean cache-commit forward]
F --> C
S --> L[Denoised latent block]
L --> V[Streaming Wan VAE decoder]
V --> O[Runtime V2 video frames]
Reviews (2): Last reviewed commit: "Fix LongSANA session isolation and rollo..." | Re-trigger Greptile |
| if max(end_frame, height, width) > max_sequence_length: | ||
| raise ValueError( | ||
| "LongSana RoPE position exceeds the released 1024-position table: " | ||
| f"end_frame={end_frame}, height={height}, width={width}." | ||
| ) |
There was a problem hiding this comment.
The application accepts any positive --total-blocks value, but this code rejects absolute positions beyond 1024. Since the first block contains 11 latent frames and every later block contains 10, a request for 103 or more blocks passes initial validation and fails only after a long partial rollout. Validate the maximum block count before generation begins, or support positions beyond 1024.
Knowledge Base Used:
There was a problem hiding this comment.
Fixed in 8899b65: the shared 1024-position constant derives a 102-block maximum, the app rejects 103+ before model setup, and the per-session cache also guards direct callers. Boundary tests cover 102 accepted and 103 rejected.
|
/ok to test 63053a2 |
|
/ok to test 8899b65 |
1 similar comment
|
/ok to test 8899b65 |
Summary
Validation