fix: load checkpoints in weights-only mode - #601
Merged
Conversation
Use explicit weights_only=True for .pt, .pth, and .ckpt reads from local paths, Hugging Face cache entries, S3, and the distributed-checkpoint cache. This keeps loading behavior consistent across supported PyTorch versions and matches the state-dict return contract. Keep safetensors handling and tensor state-dict compatibility unchanged. Add coverage for non-weight objects and normal tensor-only checkpoints across the supported legacy extensions. Signed-off-by: Jonathan McCaffrey <jmccaffrey@nvidia.com>
Contributor
The PR appears safe to merge, with a non-blocking test-coverage gap for valid S3 and distributed-cache checkpoint reads. Findings
|
jarcherNV
approved these changes
Sep 9, 2026
Collaborator
Author
|
/ok to test aae515d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
The checkpoint-loading API returns state dictionaries. Loading legacy formats in weights-only mode keeps that contract consistent across supported PyTorch versions without removing existing checkpoint formats.
Validation