Skip to content

fix: restore unreachable no-default-class error in load_plugin #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manunicholasjacob wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

fix: restore unreachable no-default-class error in load_plugin #2011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions garak/_plugins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,8 +416,9 @@ def load_plugin(path, break_on_fail=True, config_root=_config) -> object:
raise ValueError(
f"Unknown plugin module specification: {category}.{module_name}"
) from e
if generator_mod.DEFAULT_CLASS:
plugin_class_name = generator_mod.DEFAULT_CLASS
default_class = getattr(generator_mod, "DEFAULT_CLASS", None)
if default_class:
plugin_class_name = default_class
else:
raise ValueError(
f"module {module_name} has no default class; pass module.ClassName to target_type"
Expand Down
9 changes: 9 additions & 0 deletions tests/plugins/test_plugin_load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,3 +146,12 @@ def test_instantiate_generators(plugin_configuration):
pytest.skip("required deps not present")
assert isinstance(g, garak.generators.base.Generator)
ensure_pickle_support(g)


def test_load_plugin_module_without_default_class():
assert _plugins.load_plugin("detectors.always", break_on_fail=False) is False

with pytest.raises(ValueError) as exc_info:
_plugins.load_plugin("detectors.always")

assert "no default class" in str(exc_info.value.__cause__)