Skip to content

Align develop with main after the docs-site merge - #18

Merged
RogerLiu312 merged 5 commits into
developfrom
chore/align-develop-with-main
Sep 11, 2026
Merged

Align develop with main after the docs-site merge#18
RogerLiu312 merged 5 commits into
developfrom
chore/align-develop-with-main

Conversation

@RogerLiu312

Copy link
Copy Markdown
Collaborator

Back-merge of main into develop so the two branches agree on the intro decks.

PR #17 took only the docs-site/ changes onto main and added a redaction commit that
develop never received. Without this, develop still carries the unredacted decks and the
next sync or merge would reintroduce them.

Net effect on develop

Six lines, in the two intro decks:

- slurm-node-01 / slurm-node-02   ->  node-01 / node-02
- 10.52.32.8                      ->  10.x.x.x

Nothing else changes. git diff origin/develop -- ':!docs-site' is empty, so PR #15's
src/sflow, tests, docs/user and examples work is untouched, and every docs-site file now
matches main byte for byte.

Note on the conflict

sflow_intro_zh.html came through as an add/add conflict: the file reached each branch by a
rename from docs/developer/dev-notes/, once on develop and once via the cherry-pick on
main, so git saw two independent adds rather than a shared history. Resolved by taking
main's copy, which differs only by the redaction above.

Merging main (rather than the cherry-picked branch alone) also makes develop a superset of
main, so the two cannot silently drift again.

Verification

  • 19/19 docs-site tests pass; full versioned build succeeds at baseUrl=/nv-sflow/.
  • Neither deck contains slurm-node-* or 10.52.32.8 any more.

RogerLiu312 and others added 5 commits September 10, 2026 18:16
Slides 11 and 12 were previously marked legacy-hidden and had never been
published. Restoring them puts their content on the public docs site, and the
"Structured Error Analysis" slide carried a real allocation map: two internal
Slurm hostnames and the frontend's private address.

Replace them with neutral placeholders in both the EN and CN decks. The slide
is illustrating how an sflow run is diagnosed, so the exact host names and IP
carry no explanatory value -- only the shape of the allocation and the timeline
matter.
Docs site: language switch, Agent Skills nav, and CN intro deck
…ith-main

# Conflicts:
#	docs-site/static/sflow_intro_zh.html

@RogerLiu312 RogerLiu312 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@RogerLiu312
RogerLiu312 merged commit 49b93d0 into develop Sep 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant