ISW-5893: Routine npm package updates for the repo, not components#2002
ISW-5893: Routine npm package updates for the repo, not components#2002EdwinGuzman wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
EdwinGuzman
changed the title
bigfishdesign13
left a comment
bigfishdesign13
left a comment
There was a problem hiding this comment.
Everything looks to be updated consistently.
| }); | ||
|
|
||
| it("opens the accordion when the label is clicked", () => { | ||
| it("opens the accordion when the label is clicked", async () => { |
There was a problem hiding this comment.
Why is async now needed? And why isn't it needed for all unit tests? Is it only necessary for tests that rely on userEvent?
There was a problem hiding this comment.
Yes, only whenever userEvent is used.
| ); | ||
|
|
||
| userEvent.click(accordionLabel); | ||
| await userEvent.click(accordionLabel); |
| "vite": "5.4.18", | ||
| "vite-plugin-dts": "2.3.0", | ||
| "vite": "7.3.6", | ||
| "vite-plugin-dts": "4.5.4", |
There was a problem hiding this comment.
Are all these updates based on recommendations from the bot?
There was a problem hiding this comment.
The dependabot bot? Sort of. Sometimes they recommended an even higher version.
I think in this case it was higher but I had to manually find one that was compatible with the rest of our packages and versions.
7emansell
left a comment
7emansell
left a comment
There was a problem hiding this comment.
Also interested in the new async/await on click events but otherwise running smoothly
|
@bigfishdesign13 @7emansell The async/await update is specific to the It's now all async/await. This is great and I didn't even realize before that user-event 13.x is deprecated. |
4 participants
Fixes JIRA ticket ISW-5893
This PR does the following:
npm audit.How has this been tested?
Accessibility concerns or updates
Checklist:
Front End Review: