[UI] Drive image replacement transitions by identity - #93
Closed
NachoSoto wants to merge 3 commits into
Closed
Conversation
NachoSoto
marked this pull request as ready for review
September 3, 2026 19:35
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
NachoSoto
commented
Sep 3, 2026
Owner
Author
|
Superseded by the simpler WatchChess hybrid approach: the tournament cell remains SwiftUI, but its background now uses the established UIKit AsyncImageView as a layout-neutral UIViewRepresentable. This restores the proven cross-dissolve without adding SwiftUI image lifecycle machinery. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The image carried an animated transition, but the observable renderer assignment itself was not performed in an animation transaction. On a physical device the placeholder could therefore snap to the final image even though the image identity changed.
The clear placeholder remains scoped to the empty/loading branch; an always-present clear layer was removed in response to review because it was redundant.
Validation
swiftlint --config .swiftlint.yml --strict(0 violations across 34 files)ChessUITournamentstests and app build using the checked-in Bazel repository definitionRecording
ios18-corrected-placeholder-transition.mp4