#43 Add javadoc copyright footer and brand CSS - #60
Open
krh372 wants to merge 1 commit into
Open
Conversation
ptwohig
self-requested a review
August 21, 2026 02:43
Contributor
|
You should give this one a visual pass. I tried to apply it to Crossfire's javadocs and it looked terrible. If the text is hot pink it's a bit much unless we make the whole page navy. |
ptwohig
requested changes
Aug 22, 2026
ptwohig
left a comment
Contributor
There was a problem hiding this comment.
It looks like it got wrecked - https://apidocs.namazustudios.com/?product=elements&version=3.9.0-SNAPSHOT-0f25e2102&uri=javadoc%2Findex.html
Need to fiddle with the CSS to get it looking better.
Collaborator
Author
|
@ptwohig Is there a way to test this with your CSS additions to make sure there are no conflicts? |
Contributor
|
@krh372 Every push you make to any branch will result in the docs being deployed to the site. So you can review it there. Unfortunately, it takes a whole build to do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bottomfooter to the rootmaven-javadoc-pluginconfig: "Copyright (c) {currentYear} Namazu Studios LLC. All rights reserved." (applies to every module since the plugin is configured once at the root).src/main/javadoc/stylesheet.csswith brand colors (hot pink #FF0099, navy #0D1335) applied via the raw-stylesheetfilejavadoc option (Maven's ownaddStylesheets/stylesheetfileparameters only resolve paths relative to each module's ownsrc/main/javadoc/, which doesn't work for a single shared file across an 84-module reactor).Test plan
sdk-modellocally (mvn -pl sdk-model javadoc:javadoc) and visually confirmed:Closes #43