#46 Consolidate redundant ClassGraph scans during Element loading - #72
Merged
Conversation
DefaultElementLoaderFactory ran ~11 independent ClassGraph scans per element load: 5 package-scoped scans (services, produced events, consumed events, default attributes, required attributes), each also triggering its own unrestricted probe scan via rejectOtherElementPackages, plus the initial module-definition scan. Consolidated into 3: the module-definition scan, a single reject-list probe (findOtherElementPackageNames), and one shared enableAllInfo() scan (scanElementPackage) that all five metadata extractions now read from instead of re-scanning.
ptwohig
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultElementLoaderFactoryran ~11 independentClassGraphscans per Element load: 5 package-scoped scans (services, produced events, consumed events, default attributes, required attributes), each also triggering its own unrestricted probe scan viarejectOtherElementPackages, plus the initial module-definition scan.findOtherElementPackageNames, computed once instead of once per extraction), and one sharedenableAllInfo()scan (scanElementPackage) that all five metadata extractions now read from instead of each re-scanning.enableAllInfo()is a strict superset of every info-flag combination the 5 original scans requested individually.Fixes #46
Test plan
mvn -pl sdk-spi -am install— compiles cleanlymvn -pl sdk-test test— 27/27 tests pass, includingElementLoaderTest,ApiElementLoaderTest,FlatElementPathLoaderTest, which exercise the full isolated-classloader element-loading pipeline (services, produced/consumed events, default/required attributes) against real test-element fixturesmvn -pl sdk-spi-guice test— 3/3 tests pass