fix: the inbox opens a review at its diff, not at the empty working tree - #85
Merged
Conversation
The open redirect pointed at the session's bare root. The UI sends that to /diff, and /diff without a ref shows the working-tree diff, which is empty for a clean worktree at the pull request's head — so the page said "No changes found" while the imported findings sat in the base-sha session it never looked at. The redirect now carries /diff?ref=<base sha>, the URL shape the CLI itself opens. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w
Nothing imports it; the tests reach it through openPreparedSession and the open route. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inbox's
/open/:idredirected to the session's bare root URL. The UI redirects/to/diff, and/diffwithout arefshows the working-tree diff — empty for a clean worktree at the PR head. The page said "No changes found", and the imported findings sat in the base-sha session the page never looked at.The open path now sends the browser to
/diff?ref=<base sha>, the same URL shape the CLI itself opens. Bumps to 0.10.11.🤖 Generated with Claude Code
https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w