fix(release): preserve PR notes and validate WinGet access - #658
Open
pascalandr wants to merge 2 commits into
Open
fix(release): preserve PR notes and validate WinGet access#658pascalandr wants to merge 2 commits into
pascalandr wants to merge 2 commits into
Conversation
Prepend the merged stable release pull request body to GitHub's generated notes so user-facing highlights are present from the moment a release is created. Prerelease behavior remains unchanged. Validate that the configured WinGet token can create and delete a temporary branch in the contributor fork before invoking Komac. This catches the exact permission failure that blocked v0.19.0 and documents supported writable token types. Validated with actionlint, a live associated-PR lookup for the v0.19.0 merge commit, a temporary fork branch create/delete check, and winget manifest validation for the manual 0.19.0 submission.
Run the Windows Rust test binary with one test thread so process-election tests do not compete for PowerShell/CIM process identity probes on slower GitHub runners. The Electron and Tauri startup scenario remains concurrent inside its integration test; only unrelated Rust tests stop running beside it. Validated with actionlint and cargo test --locked -- --test-threads=1 on Windows (86 passed).
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/32718172386 Artifacts expire in 7 days.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The v0.19.0 WinGet job reached Komac successfully, but
WINGET_GITHUB_TOKENcould not executeCreateRefinpascalandr/winget-pkgs. The repository secret has been replaced with the currently authenticated writable GitHub CLI token.Validation
actionlint .github/workflows/reusable-release.yml .github/workflows/update-winget.ymldb0716e7pascalandr/winget-pkgswinget validatesucceeded for the v0.19.0 manifestsManual WinGet submission: microsoft/winget-pkgs#423225