Skip to content

Send Unown form via webhook - #284

Open
evenly-epic-mule wants to merge 1 commit into
Noctem:developfrom
evenly-epic-mule:webhook_unown_form
Open

Send Unown form via webhook#284
evenly-epic-mule wants to merge 1 commit into
Noctem:developfrom
evenly-epic-mule:webhook_unown_form

Conversation

@evenly-epic-mule

Copy link
Copy Markdown
Contributor

No description provided.

@baskettcase

Copy link
Copy Markdown

I have yet to see one! Heh

@tallypokemap

Copy link
Copy Markdown

Should this also be added to db and the frontend? @evenly-epic-mule

@RobTwoThree

Copy link
Copy Markdown

Has this been successfully tested with PokeAlarm for example? I know PR #250 works for sure but it was using encounter and only sending form to the webhook of Unown only.

@evenly-epic-mule

Copy link
Copy Markdown
Contributor Author

@tallypokemap actually yes, but I'm not sure how at best, because adding a new column for only one Pokemon is kind of a waste of resources

I think we should come up with a draft for some extra details like "XL Karp", "Unown Type", ...

@ghost

ghost commented Jun 15, 2017

Copy link
Copy Markdown

@tallypokemap @evenly-epic-mule PGScout branch has implemented Unown form (smallint column). The form gets sent as an INT to PA. PA doesn't convert the INT as of right now.

One column for a pokemon is a bit wasteful. Most values will be inserted as None/Null though.

@ghost

ghost commented Jun 19, 2017

Copy link
Copy Markdown

@Avatar690 Actually in brach 3.2 of PA Deadly has put in the capability for

DTS and it does convert the int.

@ghost

ghost commented Jun 23, 2017

Copy link
Copy Markdown

@ifindpokemons awesome. Ill have to fix my alarms!

Sent from my LGE LG-H820 using FastHub

RobTwoThree pushed a commit to RobTwoThree/Monocle that referenced this pull request Dec 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants