fix(traefik): file provider + panel host resolution for domain routing - #13
Merged
Merged
Conversation
…uting Setting a domain on the panel (or any file-based dynamic route) had no effect: the Nomad-variant Traefik config only declared the consulCatalog provider, so the dynamic config files nomploy writes to /etc/nomploy/traefik/dynamic (e.g. the panel's own domain router) were never loaded. Also the panel route targets http://nomploy:3000 (the app container name), which doesn't resolve when Traefik runs on the host network. - Add a Traefik 'file' provider (directory watch) in both install.sh and initializeTraefikNomad (nomad-setup.ts). - Add '--add-host nomploy:127.0.0.1' to the Traefik container so the panel route resolves to the host-networked app. Verified live: after this, http→https redirect works and the panel serves on its domain with a valid Let's Encrypt certificate. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Thank you for your contribution! Please sign our Contributor License Agreement by posting the following comment: I have read the CLA Document and I hereby sign the CLA Peter Gonda seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found live: setting a domain on the panel did nothing because the Nomad-variant Traefik config only had the
consulCatalogprovider — so file-based dynamic routes nomploy writes to/etc/nomploy/traefik/dynamic(incl. the panel's own domain) were never loaded. The panel route also targetshttp://nomploy:3000(container name), unresolvable on host networking.fileprovider (watch) toinstall.shandinitializeTraefikNomad.--add-host nomploy:127.0.0.1so the panel route resolves to the host-networked app.Verified on a live server: http→https redirect + panel served on its domain with a valid Let's Encrypt cert.
🤖 Generated with Claude Code