fix: Nomad service deploys actually schedule + pull images - #14
Merged
Merged
Conversation
Found by deploying a service through the UI on the live server. Two blockers:
1. nomad CLI missing in the app image. The deploy pipeline runs 'nomad job run'
to submit to the control plane's own Nomad, but the container had no nomad
binary -> '/bin/sh: nomad: not found', so nothing was scheduled (and the
deploy falsely reported success). Install the Nomad CLI in the Dockerfile.
2. Docker driver couldn't pull ANY image. The Nomad docker plugin sets
auth.config = /root/.docker/config.json, but that file didn't exist, so the
driver failed every pull ('Failed to open auth config file'), even public
nginx. install.sh and the bootstrap now create an empty {"auths":{}} config
before Nomad starts (docker login fills it for private registries later).
Verified live: after these, a compose (nginx) deployed via the UI schedules on
Nomad, the container runs, and curl returns HTTP 200.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Thank you for your contribution! Please sign our Contributor License Agreement by posting the following comment: I have read the CLA Document and I hereby sign the CLA Peter Gonda seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by deploying a service through the UI on a live server. Two blockers, both fixed + verified live (nginx compose → scheduled on Nomad → container running → curl HTTP 200):
nomad job runinside the container to submit to the control plane's Nomad, but there was nonomadbinary (nomad: not found), so nothing scheduled and the deploy falsely reported success. Now installed in the Dockerfile.auth.config = /root/.docker/config.jsonpointed at a missing file, so every pull failed (even public nginx).install.sh+ bootstrap now create an empty{"auths":{}}config before Nomad starts.🤖 Generated with Claude Code