panel: render custom (data-URI) pack logos in the store gallery - #18
Merged
Merged
Conversation
The registry now publishes a kind="custom" icon (a self-contained logo as a data-URI src) for packs with no Simple Icons glyph, e.g. goliash. Teach PackLogo to render it as an <img src>, and add the variant to the PackIcon type (add-pack.tsx + pack-registry.ts). Unknown kinds still fall back to the name-guess → monogram path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the registry change (Nomploy/nomad-packs#142): the registry now publishes a
kind: "custom"icon — a self-contained logo as adata:image/svg+xmlsrc— for packs with no Simple Icons glyph (e.g. goliash).PackLogo(add-pack.tsx) gains akind === "custom"branch that renders<img src={icon.src}>.PackIcontype updated in bothadd-pack.tsxandpackages/server/src/setup/pack-registry.ts(the mapper already forwardsiconuntouched, sosrcwas surviving at runtime — this just types it).Type-clean: the two changed files have no tsc errors (the 8 pre-existing
tscerrors on main are unrelated — logs/show, schedules, autoscaler, nomad.ts 1303/1393).Needs a panel redeploy to take effect.
🤖 Generated with Claude Code