Auto create .aws folder if needed - #7
Open
sweep-ai-deprecated[bot] wants to merge 5 commits into
Open
Conversation
Contributor
Author
There was a problem hiding this comment.
Nice work on adding the condition to check and create the .aws directory if it doesn't exist. However, there's a small issue that needs to be addressed:
- In
index.ts, you have duplicate import statements on lines 15-16. You only need to importIPackageJsonandjoinfrompathonce. Please remove the duplicates.
Keep up the good work!
Contributor
|
There's other places where .aws folder is needed. Can you make it a reusable function, and use it everywhere it's needed? |
Contributor
|
Don't do it at the beginning of the file, run it only when a command needs it. So should be inside whatever commands need it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a check at the start of the index.ts file to see if the .aws folder exists. If it doesn't exist, the code will create the folder using the 'fs' module in Node.js.
Changes Made:
Testing:
Related Issue:
Link to Issue #1
Fixes #1.
To checkout this PR branch, run the following command in your terminal: