Conversation
petlenz
force-pushed
the
fix-354-t2s-constant-mul
branch
from
July 25, 2026 12:33
f3cab22 to
5ec41ff
Compare
petlenz
force-pushed
the
fix-354-t2s-constant-mul
branch
2 times, most recently
from
July 25, 2026 14:16
cd9baf2 to
a6794a3
Compare
petlenz
force-pushed
the
fix-354-t2s-constant-mul
branch
2 times, most recently
from
July 26, 2026 12:14
f81b5a6 to
ea880c0
Compare
petlenz
force-pushed
the
fix-354-t2s-constant-mul
branch
from
July 26, 2026 12:43
ea880c0 to
e3cbfae
Compare
petlenz
force-pushed
the
fix-354-t2s-constant-mul
branch
from
July 26, 2026 17:18
e3cbfae to
4f47221
Compare
petlenz
force-pushed
the
fix-354-t2s-constant-mul
branch
2 times, most recently
from
July 26, 2026 18:16
35453bf to
89df391
Compare
petlenz
force-pushed
the
fix-354-t2s-constant-mul
branch
from
July 26, 2026 18:40
89df391 to
e5045a7
Compare
constant_mul::dispatch(tensor_to_scalar_mul) handled a numeric LHS by merging it into the coefficient, but a non-numeric scalar_wrapper LHS fell through the same path: the factor was never inserted and the coefficient was reset to the wrapped default, so wrapper(x) * (trace(A)*det(A)) evaluated as if x were 1. The promoted route (plain x * (f*g)) goes through mul_base and was correct, which is why tests missed it - the bug fires whenever the wrapper is the visitor's LHS. Non-numeric wrappers are now inserted as factors via push_or_combine (merging with an existing wrapper child through the unwrap-multiply- rewrap path). Signed-off-by: petlenz <peterlenz89.pl@gmail.com>
A single-shot find/combine threw 'duplicate child insertion' when the combined factor collided with another existing child (w(x)*w(x) -> w(x^2) meeting a stored w(x^2)) - the same pattern merge_or_insert_mul already loops on. Pre-existing hole; #354's new route made it easier to reach. Regression test builds the chained collision explicitly. Signed-off-by: petlenz <peterlenz89.pl@gmail.com>
petlenz
force-pushed
the
fix-354-t2s-constant-mul
branch
from
July 26, 2026 19:03
e5045a7 to
7a945d5
Compare
petlenz
added this pull request to stack #425
September 15, 2026 20:15
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #354. Stacked on #405.
wrapper(x) * (trace(A)*det(A))→1*det(A)*tr(A)— the symbolic factor x vanished and the coefficient was reset. Whentry_numericfails on the LHS wrapper,constant_mul::dispatch(tensor_to_scalar_mul)never inserted it. The promoted route (x * (f*g)) goes throughmul_baseand was correct, which is why the suite missed it.Fix
Non-numeric wrappers insert as factors via
push_or_combine(forward-declared; merging with an existing wrapper child through the existing unwrap-multiply-rewrap path). Numeric path unchanged.Tests
Typed lock-in across all three dims (wrapper-first construction so the regression can't dodge through the promoted route). Full suite: 2445/2445 pass.