[19.0][FIX] website_event_filter_city: fix visible item count with city filters. - #545
Merged
OCA-git-bot merged 1 commit intoAug 25, 2026
Merged
Conversation
Contributor
|
Hi @pilarvargas-tecnativa, |
OCA-git-bot
added
series:19.0
mod:website_event_filter_city
pedrobaeza
changed the title
adasatorres-tecnativa
force-pushed
the
19.0-fix-website_event_filter_city
branch
from
August 18, 2026 10:41
efc134a to
55759fb
Compare
Author
|
@pilarvargas-tecnativa, Right now, the city filter should work the same way as the country filter, taking into account that the country filter is affected by the other filters, as well as by the city filter. |
dcanete-pyming
left a comment
dcanete-pyming
left a comment
There was a problem hiding this comment.
Functional review:
- Verified that selecting a city updates the available countries.
- Verified that selecting a country updates the available cities.
- Verified that text search updates both city and country filters.
- Verified that clearing the filters restores all available options.
- Confirmed that incompatible events are not displayed.
The functional behavior works as expected.
adasatorres-tecnativa
force-pushed
the
19.0-fix-website_event_filter_city
branch
from
August 19, 2026 07:52
55759fb to
7616880
Compare
pedrobaeza
requested changes
Aug 19, 2026
adasatorres-tecnativa
force-pushed
the
19.0-fix-website_event_filter_city
branch
from
August 19, 2026 11:10
7616880 to
9ae9bce
Compare
Author
|
ping @pedrobaeza |
adasatorres-tecnativa
force-pushed
the
19.0-fix-website_event_filter_city
branch
from
August 25, 2026 09:38
9ae9bce to
a5d26ca
Compare
pedrobaeza
force-pushed
the
19.0-fix-website_event_filter_city
branch
from
August 25, 2026 09:59
a5d26ca to
97e8985
Compare
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
adasatorres-tecnativa
force-pushed
the
19.0-fix-website_event_filter_city
branch
from
August 25, 2026 10:03
97e8985 to
27c0038
Compare
pedrobaeza
force-pushed
the
19.0-fix-website_event_filter_city
branch
from
August 25, 2026 10:05
27c0038 to
97e8985
Compare
adasatorres-tecnativa
force-pushed
the
19.0-fix-website_event_filter_city
branch
from
August 25, 2026 10:05
97e8985 to
f592141
Compare
Member
|
@adasatorres-tecnativa I already pushed the correct version. It was with |
pedrobaeza
force-pushed
the
19.0-fix-website_event_filter_city
branch
from
August 25, 2026 10:06
f592141 to
97e8985
Compare
Contributor
|
Congratulations, your PR was merged at d7730b8. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Tecnativa TT64025
@pilarvargas-tecnativa @pedrobaeza.
Ensure the city filter takes all other active filters into account when calculating visible events.