[19.0][IMP] partner_event: prefer the attendee partner as default recipient - #548
Open
moylop260 wants to merge 1 commit into
Open
[19.0][IMP] partner_event: prefer the attendee partner as default recipient#548moylop260 wants to merge 1 commit into
moylop260 wants to merge 1 commit into
Conversation
moylop260
force-pushed
the
19.0-partner-event-default-recipients-moy
branch
3 times, most recently
from
August 30, 2026 20:04
7802a7c to
6d4abc1
Compare
Author
|
@CRogos @nihelgabsi-acsone @pedrobaeza @MohamedOsman7 @vincent-hatakeyama |
moylop260
marked this pull request as draft
August 30, 2026 20:12
moylop260
marked this pull request as ready for review
August 30, 2026 20:30
pedrobaeza
reviewed
Aug 31, 2026
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
If there are extra default recipients, this will overwrite them. Can you just replace one by the other?
The generic default-recipient heuristics pick partner_id, which is the person that made the booking, or fall back to the plain email typed in the registration. Mails composed from a registration are meant for the attendee, so when the module has resolved an attendee_partner_id use it as the recipient instead. Only that recipient is swapped inside the computed list, so any extra partner contributed by another module is kept.
moylop260
force-pushed
the
19.0-partner-event-default-recipients-moy
branch
from
September 7, 2026 04:31
6d4abc1 to
192d3b9
Compare
Author
|
Good catch! I have created the changes Please, review |
pedrobaeza
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generic default-recipient heuristics of mail pick
partner_id, which is the person that made the booking, or fall back to the plain email typed in the registration. Mails composed from a registration (mail templates, the composer) are meant for the attendee, so when the module has resolved anattendee_partner_idthis uses it as the default recipient instead.When no attendee partner is resolved, the generic heuristics still apply unchanged.
The override keeps the
with_cc/all_toskeyword arguments 19.0 declares on the original and delegates everything else tosuper().