Skip to content

[18.0][FIX] fleet_vehicle_inspection: fix dead search filters and unsafe multi-record button_confirm #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
CristianoMafraJunior wants to merge 2 commits into
base: 18.0
Choose a base branch
from
Draft

[18.0][FIX] fleet_vehicle_inspection: fix dead search filters and unsafe multi-record button_confirm #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0a8ffe
[FIX] fleet_vehicle_inspection_template: chatter
CristianoMafraJunior Sep 3, 2026
0b8fbd8
[FIX] fleet_vehicle_inspection: fix dead search filters and unsafe mu…
CristianoMafraJunior Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions fleet_vehicle_inspection/models/fleet_vehicle_inspection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,13 @@ def button_confirm(self):
raise ValidationError(
_("Only inspections in 'draft' or 'cancel' states can be confirmed")
)
if self.amount:
if not self.service_type_id:
raise ValidationError(_("Must select service type"))
self.service_id = self.env["fleet.vehicle.log.services"].create(
self._prepare_fleet_vehicle_log_services_vals()
)
for rec in self:
if rec.amount:
if not rec.service_type_id:
raise ValidationError(_("Must select service type"))
rec.service_id = self.env["fleet.vehicle.log.services"].create(
rec._prepare_fleet_vehicle_log_services_vals()
)
self.state = "confirmed"
return True

Expand Down
8 changes: 4 additions & 4 deletions fleet_vehicle_inspection/views/fleet_vehicle_inspection_views.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,13 +122,13 @@
/>
<filter
string="Inspection Completed"
name="result"
domain="[('state','=','completed')]"
name="confirmed"
domain="[('state','=','confirmed')]"
/>
<filter
string="Inspection Canceled"
name="result"
domain="[('result','=','cancel')]"
name="cancel"
domain="[('state','=','cancel')]"
/>
<separator />
<filter
Expand Down
6 changes: 1 addition & 5 deletions fleet_vehicle_inspection_template/views/fleet_vehicle_inspection_template.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,7 @@
</page>
</notebook>
</sheet>
<div class="oe_chatter">
<field name="message_follower_ids" widget="mail_followers" />
<field name="activity_ids" widget="mail_activity" />
<field name="message_ids" widget="mail_thread" />
</div>
<chatter />
</form>
</field>
</record>
Expand Down
Loading