Skip to content

[18.0][FIX] base_geoengine#467

Open
edescalona wants to merge 1 commit into
OCA:18.0from
BinhexTeam:18.0-fix-base_geoengine
Open

[18.0][FIX] base_geoengine#467
edescalona wants to merge 1 commit into
OCA:18.0from
BinhexTeam:18.0-fix-base_geoengine

Conversation

@edescalona

Copy link
Copy Markdown

@BinhexTeam
T24126

Guard GeoEngine renderer and info-box popup against missing data.

Context:
In the GeoEngine (map) view of base_geoengine, several JavaScript errors occurred when interacting with the map, the records panel, and the infobox popup. These errors were reproduced in Field Service → Orders (map view), but the root cause lies within base_geoengine and affects any model using GeoEngine views.

Bugs fixed:

  1. Exception when zooming to a record without geometry.
  2. Exception when rendering the infobox popup. The info_box template accesses the fields as record..value, but renderingContext exposed the relational record (whose fields are in _values/data, not accessible as .value). Furthermore, if the template referenced a field not declared in the view, record. was undefined and .value threw "Cannot read properties of undefined (reading 'value')".

@edescalona
edescalona marked this pull request as ready for review July 16, 2026 19:54
@edescalona

Copy link
Copy Markdown
Author

ping @LINTOANTONY007 @nbessi @rrebollo

@rrebollo rrebollo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants