[16.0][FIX] pms: hide PMS-only fields from users without PMS access

[DarioLodeiros]

Problem

On a database where the PMS coexists with other business lines, any internal user without a PMS group gets an AccessError when opening plain business forms:

You are not allowed to access 'Partner Checkins' (pms.checkin.partner) records.

The views this module inherits add PMS fields without any group restriction, and those fields (or their computes) read PMS models whose ACLs are limited to pms.group_pms_user / pms.group_pms_manager:

Form	Field	Model it reads
res.partner	reservations_count (compute)	pms.checkin.partner
product.template / product.product	property_daily_limits	ir.pms.property
product.pricelist	pms_sale_channel_ids	pms.sale.channel
product.pricelist.item	allowed_board_service_room_type_ids	pms.board.service.room.type

It goes unnoticed on hotel-only databases, where every internal user has a PMS group. It shows up as soon as the same Odoo hosts staff unrelated to the property (accounting, sales, another business unit), who then cannot open a contact, a product or a pricelist at all.

How to reproduce

1. Take a user with base.group_user (and, to rule out unrelated ACLs, base.group_system) and no PMS group.
2. Open any contact form → AccessError on pms.checkin.partner.
3. Same with a product, a pricelist and a pricelist item, on the models listed above.

Fix

Add groups="pms.group_pms_user" to those elements, so they are dropped from the arch for users without PMS access while the rest of the form stays usable.

Whole blocks are guarded rather than only the offending field: when a guarded field is referenced from the attrs or domain of a sibling that stays visible (is_pms_available on the pricelist, allowed_board_service_room_type_ids in the domain of board_service_room_type_id), hiding it alone breaks the view for a different reason.

The commented-out groups_id line on the res.partner view is dropped as well: Odoo 16 rejects groups_id on inherited views ("Inherited view cannot have 'groups' defined in the record"), so the groups attribute is the supported mechanism.

Testing

Verified on a production database hosting a hotel plus an unrelated business line, with three profiles — an administrator without PMS groups, a plain internal user, and a PMS manager — across res.partner, product.template, product.product, product.pricelist, product.pricelist.item, account.journal, account.move, account.move.line, account.payment, account.bank.statement, res.users and res.company: no access errors after the change, and users with PMS groups keep seeing every PMS field as before.

[DarioLodeiros]

/ocabot merge minor

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-440-by-DarioLodeiros-bump-minor, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 43f7c06. Thanks a lot for contributing to OCA. ❤️