Skip to content

[18.0][FWP] password_security_tests: PR #999 PR #1001 - #1002

Merged
OCA-git-bot merged 4 commits into
OCA:18.0from
Tecnativa:18.0-fwp-password_security-tests
Sep 8, 2026
Merged

[18.0][FWP] password_security_tests: PR #999 PR #1001#1002
OCA-git-bot merged 4 commits into
OCA:18.0from
Tecnativa:18.0-fwp-password_security-tests

Conversation

@Andrii9090-tecnativa

@Andrii9090-tecnativa Andrii9090-tecnativa commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

@OCA-git-bot OCA-git-bot added series:18.0 mod:password_security Module password_security labels Sep 7, 2026
@pedrobaeza pedrobaeza added this to the 18.0 milestone Sep 8, 2026
@pedrobaeza

pedrobaeza commented Sep 8, 2026

Copy link
Copy Markdown
Member

The CI fails by other thing... you should add an extra commit adding in test-requirements.txt the library odoo-test-helper.

adasatorres-tecnativa
adasatorres-tecnativa approved these changes Sep 8, 2026
View reviewed changes

@adasatorres-tecnativa adasatorres-tecnativa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review.

@adasatorres-tecnativa

adasatorres-tecnativa commented Sep 8, 2026

Copy link
Copy Markdown

I think we could try pinning the anyio version in the fastapi addon to one that doesn't raise this DeprecationWarning.

From what I can see, the issue comes from Starlette's TestClient using anyio.abc.BlockingPortal. Maybe anyio<4.15 would be enough to avoid it. What do you think about giving it a try?

@pedrobaeza

pedrobaeza commented Sep 8, 2026

Copy link
Copy Markdown
Member

@lmignon are you aware of this incompatibility in FastAPI?

@lmignon

lmignon commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@lmignon are you aware of this incompatibility in FastAPI?

@pedrobaeza Yes, I'm aware and here it's how you can fix it OCA/rest-framework#640
image

regards

@pedrobaeza

pedrobaeza commented Sep 8, 2026

Copy link
Copy Markdown
Member

Thanks, Laurent. @Andrii9090-tecnativa can you proceed?

@pedrobaeza

pedrobaeza commented Sep 8, 2026

Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot

OCA-git-bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1002-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit f9a22c4 into OCA:18.0 Sep 8, 2026
9 of 11 checks passed
@OCA-git-bot

OCA-git-bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 6e56972. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
pedrobaeza deleted the 18.0-fwp-password_security-tests branch September 8, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes
+1 more reviewer
@adasatorres-tecnativa adasatorres-tecnativa adasatorres-tecnativa approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:password_security Module password_security series:18.0

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Andrii9090-tecnativa @pedrobaeza @adasatorres-tecnativa @lmignon @OCA-git-bot