[18.0][MIG] users_ldap_groups : Migration to v18 - #889
Open
cvinh wants to merge 41 commits into
Open
Conversation
…o a transientmodel
…p beneath the module's name in kanban view
Also improve tests and handle new warning
Currently translated at 100.0% (26 of 26 strings) Translation: server-auth-16.0/server-auth-16.0-users_ldap_groups Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-users_ldap_groups/es/
Currently translated at 100.0% (26 of 26 strings) Translation: server-auth-16.0/server-auth-16.0-users_ldap_groups Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-users_ldap_groups/it/
res.company.ldap.operator operators should be private methods; public methods allow arbitrary LDAP queries via JSON-API
Currently translated at 100.0% (26 of 26 strings) Translation: server-auth-16.0/server-auth-16.0-users_ldap_groups Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-users_ldap_groups/pt_BR/
Co-authored-by: Hpar <raph@hpar.fr>
The group mapping in query mode fails if LDAP returns binary data in any of the fields. This adds a function that handles such situation by base64 encoding it. The new test test_users_ldap_groups_ldap_returns_binary_data covers the common case where LDAP return binary data in thumbnailPhoto.
pedrobaeza
changed the title
Member
|
/ocabot migration users_ldap_groups |
cvinh
force-pushed
the
18.0-mig-users_ldap_groups
branch
2 times, most recently
from
January 19, 2026 02:37
98ce4bc to
39c9a20
Compare
|
LGTM 👍 , tested migrated module with openldap and it works |
hbrunn
requested changes
Feb 20, 2026
cvinh
force-pushed
the
18.0-mig-users_ldap_groups
branch
from
February 20, 2026 18:17
39c9a20 to
2e57e7f
Compare
hbrunn
approved these changes
Feb 21, 2026
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
Contributor
Author
|
@mcodes-o can you approve please so it can be merged ? |
github-actions
Bot
removed
the
stale
Contributor
You forgot to approve it. :-) |
dinkotom
pushed a commit
to dinkotom/server-auth
that referenced
this pull request
Sep 7, 2026
- res.users._login is an instance method in Odoo 19 (no db argument, no separate cursor) - follow the auth_ldap 19.0 implementation - res.users.groups_id was renamed to group_ids; use fields.Command - auth_ldap renamed the model class CompanyLDAP -> ResCompanyLdap (tests) - res.users.authenticate() no longer takes the database name (tests) - drop the cursor mocking in tests: login now runs in the current cursor Based on the 18.0 migration by Cyril Vinh-Tung (Invitu), OCA#889. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dinkotom
pushed a commit
to dinkotom/server-auth
that referenced
this pull request
Sep 7, 2026
- res.users._login is an instance method in Odoo 19 (no db argument, no separate cursor) - follow the auth_ldap 19.0 implementation - res.users.groups_id was renamed to group_ids; use fields.Command - auth_ldap renamed the model class CompanyLDAP -> ResCompanyLdap (tests) - res.users.authenticate() no longer takes the database name (tests) - drop the cursor mocking in tests: login now runs in the current cursor - drop guards for falsy return values: in Odoo 19 both res.users._login and res.company.ldap._get_or_create_user raise AccessDenied instead of returning False - simplify the fake LDAP connection in tests (unused stubs) - add python-ldap to the repository requirements.txt Based on the 18.0 migration by Cyril Vinh-Tung (Invitu), OCA#889. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.