Skip to content

[17.0][ADD] fs_attachment_azure - #643

Open
grindtildeath wants to merge 6 commits into
OCA:17.0from
camptocamp:17.0-add-fs_attachment_azure
Open

[17.0][ADD] fs_attachment_azure#643
grindtildeath wants to merge 6 commits into
OCA:17.0from
camptocamp:17.0-add-fs_attachment_azure

Conversation

@grindtildeath

Copy link
Copy Markdown

No description provided.

@OCA-git-bot OCA-git-bot added series:17.0 mod:fs_attachment_azure Module fs_attachment_azure labels Jul 13, 2026
@grindtildeath

Copy link
Copy Markdown
Author

Hello @lmignon
I reused most of the work you did on fs_attachment_s3 , so feel free to let me know how that looks for you 🙏

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grindtildeath Thank you for the proposal. Don't forget to run the tests locally before submitting your PR 😏 Some little typo remains to be fixed.

Comment thread fs_attachment_azure/tests/common.py Outdated
Comment thread fs_attachment_azure/tests/test_fs_attachment_s3.py Outdated
Comment thread fs_attachment_azure/tests/test_fs_attachment_s3.py Outdated
@grindtildeath
grindtildeath force-pushed the 17.0-add-fs_attachment_azure branch 2 times, most recently from 434daed to b84aa54 Compare July 15, 2026 19:13

@ivantodorovich ivantodorovich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Code review Only)

@lmignon

lmignon commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@grindtildeath I can't validate this code against Azure since I don't have access to an Azure environment. Once you've tested it on your side and it's ready to merge, just ping me.

@oca-cla-bot

oca-cla-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

CLA not signed

@ivantodorovich
ivantodorovich force-pushed the 17.0-add-fs_attachment_azure branch from e640656 to e3723b0 Compare August 18, 2026 17:40
@ivantodorovich
ivantodorovich force-pushed the 17.0-add-fs_attachment_azure branch from e3723b0 to cd36d74 Compare September 9, 2026 16:47
@OCA-git-bot OCA-git-bot added the mod:fs_attachment_azure_environment Module fs_attachment_azure_environment label Sep 9, 2026
Move the server environment support to fs_attachment_azure_environment.
Delete the orphaned blobs by batch during the garbage collection.
@ivantodorovich
ivantodorovich force-pushed the 17.0-add-fs_attachment_azure branch from cd36d74 to 1405953 Compare September 9, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved mod:fs_attachment_azure_environment Module fs_attachment_azure_environment mod:fs_attachment_azure Module fs_attachment_azure series:17.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants