[IMP] Add FS Storage Dynamic Routing Rules

[baimont]

No description provided.

[OCA-git-bot]

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

[baimont]

take a look @sbidoul and @AnizR

[AnizR]

take a look @sbidoul and @AnizR

Can you give some context?

[lmignon]

@baimont Could you add some user-oriented documentation explaining this new feature in the usage section?

I think this is particularly important here, as without this explanation it is quite difficult to understand what the code is doing, and someone discovering the module would otherwise have no way of knowing that this feature exists.

[baimont]

@baimont Could you add some user-oriented documentation explaining this new feature in the usage section?

I think this is particularly important here, as without this explanation it is quite difficult to understand what the code is doing, and someone discovering the module would otherwise have no way of knowing that this feature exists.

hey @lmignon, done

[lmignon]

Some little comments regarding the way you design your cache....

[simahawk]

@lmignon am I wrong to say that this does not sound as a core feature and can stay in its own module?

[lmignon]

@lmignon am I wrong to say that this does not sound as a core feature and can stay in its own module?

You're right. I've the feeling it could be developed as an extension... @baimont What do you thing about?

[baimont]

@lmignon am I wrong to say that this does not sound as a core feature and can stay in its own module?

You're right. I've the feeling it could be developed as an extension... @baimont What do you thing about?

I hesitated but IMO this is an improvement of the model_ids and field_ids fields on fs.storage that already allow to route to different storages. That's why I went for this. I can change it.

[lmignon]

@lmignon am I wrong to say that this does not sound as a core feature and can stay in its own module?

You're right. I've the feeling it could be developed as an extension... @baimont What do you thing about?

I hesitated but IMO this is an improvement of the model_ids and field_ids fields on fs.storage that already allow to route to different storages. That's why I went for this. I can change it.

The discussion is open 😏 The main goal is to avoid increasing the module's complexity by adding optional features that are not required for common use cases. Maybe we could also rethink the structure of this addon for Odoo 20 and split it into smaller modules.

[AnizR]

IMO, the feature can be in a separate module. (And so, I'll wait before approving the PR)

Otherwise, the code seems pretty clean to me, good job 🚀