Skip to content

[18.0][FIX] vcp_management: Fix color_picker Owl crash on request label creation #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BhaveshHeliconia wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[18.0][FIX] vcp_management: Fix color_picker Owl crash on request label creation #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions vcp_management/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
.. image:: https://odoo-community.org/readme-banner-image
:target: https://odoo-community.org/get-involved?utm_source=readme
:alt: Odoo Community Association

==============
VCP Management
==============
Expand All @@ -17,7 +13,7 @@ VCP Management
.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
:target: https://odoo-community.org/page/development-status
:alt: Beta
.. |badge2| image:: https://img.shields.io/badge/license-AGPL--3-blue.png
.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fversion--control--platform-lightgray.png?logo=github
Expand Down
2 changes: 1 addition & 1 deletion vcp_management/__manifest__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{
"name": "VCP Management",
"summary": """Management for your Version Control Platforms""",
"version": "18.0.1.0.1",
"version": "18.0.1.0.2",
"license": "AGPL-3",
"author": "Dixmit,Odoo Community Association (OCA)",
"website": "https://github.com/OCA/version-control-platform",
Expand Down
29 changes: 29 additions & 0 deletions vcp_management/migrations/18.0.1.0.2/pre-migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Copyright 2026 Dixmit
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
import logging

_logger = logging.getLogger(__name__)


def migrate(cr, version):
if not version:
return

_logger.info(
"Safely casting 'color' from VARCHAR to INTEGER in vcp_request_label..."
)

# 1. First, handle any edge cases where color might be empty or not a number
cr.execute("""
UPDATE vcp_request_label
SET color = '0'
WHERE color IS NULL OR color = '' OR color !~ '^[0-9]+$';
""")

# 2. Use the 'USING' clause to safely cast the strings to integers
cr.execute("""
ALTER TABLE vcp_request_label
ALTER COLUMN color TYPE int4 USING color::integer;
""")

_logger.info("Successfully converted 'color' column.")
2 changes: 1 addition & 1 deletion vcp_management/models/vcp_request_label.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class VcpRequestLabel(models.Model):

name = fields.Char(required=True, readonly=True)

color = fields.Char(default=lambda x: x._default_color())
color = fields.Integer(default=lambda x: x._default_color())

request_ids = fields.Many2many(
comodel_name="vcp.request",
Expand Down
46 changes: 20 additions & 26 deletions vcp_management/static/description/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="generator" content="Docutils: https://docutils.sourceforge.io/" />
<title>README.rst</title>
<title>VCP Management</title>
<style type="text/css">

/*
Expand Down Expand Up @@ -360,21 +360,16 @@
</style>
</head>
<body>
<div class="document">
<div class="document" id="vcp-management">
<h1 class="title">VCP Management</h1>


<a class="reference external image-reference" href="https://odoo-community.org/get-involved?utm_source=readme">
<img alt="Odoo Community Association" src="https://odoo-community.org/readme-banner-image" />
</a>
<div class="section" id="vcp-management">
<h1>VCP Management</h1>
<!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:b2557a3fa2705c48d7fc80b1fc2df6bb92e35858bcd0d25a892fa6cad65a0664
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/version-control-platform/tree/18.0/vcp_management"><img alt="OCA/version-control-platform" src="https://img.shields.io/badge/github-OCA%2Fversion--control--platform-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/version-control-platform-18-0/version-control-platform-18-0-vcp_management"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/version-control-platform&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/version-control-platform/tree/18.0/vcp_management"><img alt="OCA/version-control-platform" src="https://img.shields.io/badge/github-OCA%2Fversion--control--platform-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/version-control-platform-18-0/version-control-platform-18-0-vcp_management"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/version-control-platform&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
<p>Creates a set of modules used for handling a version control patform.</p>
<p><strong>Table of contents</strong></p>
<div class="contents local topic" id="contents">
Expand Down Expand Up @@ -406,41 +401,41 @@ <h1>VCP Management</h1>
</ul>
</div>
<div class="section" id="use-cases-context">
<h2><a class="toc-backref" href="#toc-entry-1">Use Cases / Context</a></h2>
<h1><a class="toc-backref" href="#toc-entry-1">Use Cases / Context</a></h1>
<p>The aim of this module is to allow any community to import data from a
version control system.</p>
<p>The system should be done in a way that is agnostic to the system and
the connections are handled directly by specific modules.</p>
<div class="section" id="definitions">
<h3><a class="toc-backref" href="#toc-entry-2">Definitions</a></h3>
<h2><a class="toc-backref" href="#toc-entry-2">Definitions</a></h2>
<div class="section" id="hosts">
<h4><a class="toc-backref" href="#toc-entry-3">Hosts</a></h4>
<h3><a class="toc-backref" href="#toc-entry-3">Hosts</a></h3>
<p>Hosts are the origin of data. Each host has a type that helps us know
how to integrate with the system. For example, on Github there is only
one host (github.com). However, in Gitlab there could be one for each
instance that we are integrating too.</p>
</div>
<div class="section" id="platform">
<h4><a class="toc-backref" href="#toc-entry-4">Platform</a></h4>
<h3><a class="toc-backref" href="#toc-entry-4">Platform</a></h3>
<p>We understand that a platform is an entity that can provide code and
information to our Version Control Platform (VCP). A platform could be
an organization on Github (like OCA) or Gitlab for example.</p>
</div>
<div class="section" id="repository">
<h4><a class="toc-backref" href="#toc-entry-5">Repository</a></h4>
<h3><a class="toc-backref" href="#toc-entry-5">Repository</a></h3>
<p>A repository is an origin of code. For example, <a class="reference external" href="https://github.com/OCA/version-control-platform">this
repository</a> could be
a VCP repository.</p>
</div>
<div class="section" id="requests">
<h4><a class="toc-backref" href="#toc-entry-6">Requests</a></h4>
<h3><a class="toc-backref" href="#toc-entry-6">Requests</a></h3>
<p>A request is what contributors do to propose new codes. In Github it is
a Pull request, however in Gitlab it is called Merge Request.</p>
<p>When a user makes a review on a request, it markes their resolution and
some comments. That would correspond to Reviews and Comments.</p>
</div>
<div class="section" id="rules">
<h4><a class="toc-backref" href="#toc-entry-7">Rules</a></h4>
<h3><a class="toc-backref" href="#toc-entry-7">Rules</a></h3>
<p>Inside a Platform or repository, we can apply some rules to get some
basic statistics. This rules are usually done by downloading the code
locally and then it can give some basic information like number of lines
Expand All @@ -449,20 +444,20 @@ <h4><a class="toc-backref" href="#toc-entry-7">Rules</a></h4>
</div>
</div>
<div class="section" id="usage">
<h2><a class="toc-backref" href="#toc-entry-8">Usage</a></h2>
<h1><a class="toc-backref" href="#toc-entry-8">Usage</a></h1>
<div class="section" id="creation">
<h3><a class="toc-backref" href="#toc-entry-9">Creation</a></h3>
<h2><a class="toc-backref" href="#toc-entry-9">Creation</a></h2>
<p>First step is to create a Platform. In the platform we need to set the
host (you might need to create it on gitlab) and add some Platform Keys.</p>
<p>This keys will allow us to integrate with the origin system.</p>
</div>
<div class="section" id="refresh">
<h3><a class="toc-backref" href="#toc-entry-10">Refresh</a></h3>
<h2><a class="toc-backref" href="#toc-entry-10">Refresh</a></h2>
<p>By default, the system provides some refresh rules for platforms and
repositories, however we can deactivate or activate it manualy.</p>
</div>
<div class="section" id="management-of-rules">
<h3><a class="toc-backref" href="#toc-entry-11">Management of rules</a></h3>
<h2><a class="toc-backref" href="#toc-entry-11">Management of rules</a></h2>
<p>One of the capabilities of this module is the generation of rules.</p>
<p>This rules allow us to know some information of the repository.</p>
<p>By default, the system adds some rules aligned with odoo to make it
Expand All @@ -479,23 +474,23 @@ <h3><a class="toc-backref" href="#toc-entry-11">Management of rules</a></h3>
</div>
</div>
<div class="section" id="bug-tracker">
<h2><a class="toc-backref" href="#toc-entry-12">Bug Tracker</a></h2>
<h1><a class="toc-backref" href="#toc-entry-12">Bug Tracker</a></h1>
<p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/version-control-platform/issues">GitHub Issues</a>.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
<a class="reference external" href="https://github.com/OCA/version-control-platform/issues/new?body=module:%20vcp_management%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
<p>Do not contact contributors directly about support or help with technical issues.</p>
</div>
<div class="section" id="credits">
<h2><a class="toc-backref" href="#toc-entry-13">Credits</a></h2>
<h1><a class="toc-backref" href="#toc-entry-13">Credits</a></h1>
<div class="section" id="authors">
<h3><a class="toc-backref" href="#toc-entry-14">Authors</a></h3>
<h2><a class="toc-backref" href="#toc-entry-14">Authors</a></h2>
<ul class="simple">
<li>Dixmit</li>
</ul>
</div>
<div class="section" id="contributors">
<h3><a class="toc-backref" href="#toc-entry-15">Contributors</a></h3>
<h2><a class="toc-backref" href="#toc-entry-15">Contributors</a></h2>
<ul class="simple">
<li><a class="reference external" href="https://dixmit.com">Dixmit</a><ul>
<li>Enric Tobella</li>
Expand All @@ -508,7 +503,7 @@ <h3><a class="toc-backref" href="#toc-entry-15">Contributors</a></h3>
</ul>
</div>
<div class="section" id="maintainers">
<h3><a class="toc-backref" href="#toc-entry-16">Maintainers</a></h3>
<h2><a class="toc-backref" href="#toc-entry-16">Maintainers</a></h2>
<p>This module is maintained by the OCA.</p>
<a class="reference external image-reference" href="https://odoo-community.org">
<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
Expand All @@ -521,6 +516,5 @@ <h3><a class="toc-backref" href="#toc-entry-16">Maintainers</a></h3>
</div>
</div>
</div>
</div>
</body>
</html>
Loading