[19.0][MIG] vcp_management: Migration to 19.0 - #11
Open
BhaveshHeliconia wants to merge 20 commits into
Open
Conversation
set kind field required at platform level. It doesn't makes sense to have a plateform without kind + it makes failing call of update_information AttributeError: 'vcp.platform' object has no attribute '_update_information_False'. Did you mean: '_update_information_github'?
Remove dependancy on website Create users and Organizations Remove portal dependancy Improve comments. Add Host Type Add groups Handle importing by cron add git url Add rules & cloc review Add dependancies Order of file loading Adding tests Copy with depth 1 Set default values, fix views
bad path for icon allow to delete a repository, if it has repository branch allow to fetch only 'sources' repositories, ignoring forks allow to fetch only 'active' repositories, ignoring archived repositories allow to delete a branch, if it has repository branch add last_commit_date (in github, it related to 'PushedAt' field. (https://github.com/orgs/community/discussions/24442). It's an important field that show if the repo is active, or totally abandonned Add new smart button to go from a platform to related repositories put vcp.platform.key model in dedicated file, applying OCA rule use new image.mixin, simplifying code base add branch count on repo level display all the versionsw where the module is available Add branch pattern, to fetch only branches whose names are matching a given pattern. It allows to ignore ocabot branches, in case of fetching OCA repositories use new menu items nested system Add vcp.branch menuitem, and improve display Add vcp.branch menuitem, and improve display. Fix body storage. (convert markdown into html) Add vcp.review menuitem, and improve display Add a menu entry for the vcp.request.label model. Add a Color field on labels. add link from vcp.request to vcp.review add link from vcp.request to vcp.comment get 'draft' state of pull requests. add a new 'status' field on vcp.request, that is based on 'is_draft', 'is_merged' and 'state' field to display the correct ribbon on form view / badge on list view allow to delete pull requests improve naming of field, renaming information_update into scheduled_information_update. Add a helper. Check the field by default, as it is the expected behaviour user want harmonize actions. put a path in all actions. rename xml_id of some actions. improve naming of field, renaming information_update into scheduled_information_update for vcp.repository model. Add helpers. explicit limit in cron python code. explicit limit in dron definition. add a filter to display only active requests. (draft and open) add vcp.repository.branch menu entry tests now include parameter limit
Improve texts improve readme. Add some fixes. split git logic
Some repo can have broken data that block the rule processing add a simple error mecanism to avoid blocking the cron and blocking the process of every branch
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: version-control-platform-18.0/version-control-platform-18.0-vcp_management Translate-URL: https://translation.odoo-community.org/projects/version-control-platform-18-0/version-control-platform-18-0-vcp_management/
BhaveshHeliconia
marked this pull request as draft
June 29, 2026 04:32
BhaveshHeliconia
force-pushed
the
19.0-mig-vcp_management
branch
from
June 29, 2026 04:59
e7bed0a to
bde5444
Compare
This was referenced Jun 29, 2026
BhaveshHeliconia
force-pushed
the
19.0-mig-vcp_management
branch
2 times, most recently
from
July 3, 2026 04:33
d3f09f7 to
9f6c888
Compare
BhaveshHeliconia
marked this pull request as ready for review
July 3, 2026 05:00
Author
|
Hello, @etobella @sebastienbeau @pedrobaeza @victoralmau @legalsylvain @tarteo Following the discussion in OCA/interface-git#137, I reviewed both the Based on that discussion, I first migrated the module to 19.0 while preserving the existing functionality. After that, I made a few improvements to better align and consolidate the functionality from both repositories. Each improvement has been made in a separate commit and You can find a detailed description of each improvement in the corresponding commit message, making it easier to review. I would appreciate your feedback on the proposed approach and the implementation. |
Member
|
I think it's better to simply migrate the module in this PR, and then propose those improvements once merged, for avoiding to block the whole pack due to the discussion about the improvements. |
BhaveshHeliconia
force-pushed
the
19.0-mig-vcp_management
branch
from
July 6, 2026 10:36
9f6c888 to
bde5444
Compare
Author
|
@pedrobaeza Thanks for your feedback. I have removed the improvement commits, so this PR now contains only the migration changes. The improvements can be proposed separately once the migration is merged. Could you please review it? |
Member
|
Can you add this? #17 |
Member
|
Sorry, #16 |
BhaveshHeliconia
force-pushed
the
19.0-mig-vcp_management
branch
from
July 27, 2026 07:27
bde5444 to
22e7396
Compare
Author
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.