-
-
Notifications
You must be signed in to change notification settings - Fork 118
[18.0][ADD] webservice_client_certificate_auth: new module #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vvrossem
wants to merge
3
commits into
OCA:18.0
Choose a base branch
from
camptocamp:18.0-add-webservice_client_certificate_auth
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| ============================================== | ||
| WebService - Client Certificate Authentication | ||
| ============================================== | ||
|
|
||
| .. | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| !! This file is generated by oca-gen-addon-readme !! | ||
| !! changes will be overwritten. !! | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| !! source digest: sha256:4a2f96ce5a7f3c69babb934fd5a9e2bb530fd01e335c3526d5f499774b59fd36 | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
|
|
||
| .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png | ||
| :target: https://odoo-community.org/page/development-status | ||
| :alt: Beta | ||
| .. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png | ||
| :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html | ||
| :alt: License: AGPL-3 | ||
| .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fweb--api-lightgray.png?logo=github | ||
| :target: https://github.com/OCA/web-api/tree/18.0/webservice_client_certificate_auth | ||
| :alt: OCA/web-api | ||
| .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png | ||
| :target: https://translation.odoo-community.org/projects/web-api-18-0/web-api-18-0-webservice_client_certificate_auth | ||
| :alt: Translate me on Weblate | ||
| .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png | ||
| :target: https://runboat.odoo-community.org/builds?repo=OCA/web-api&target_branch=18.0 | ||
| :alt: Try me on Runboat | ||
|
|
||
| |badge1| |badge2| |badge3| |badge4| |badge5| | ||
|
|
||
| Adds support for Client Side Certificates to the ``webservice_core`` | ||
| module. | ||
|
|
||
| **Table of contents** | ||
|
|
||
| .. contents:: | ||
| :local: | ||
|
|
||
| Configuration | ||
| ============= | ||
|
|
||
| On the webservice backend, set the authentication type to "Client | ||
| Certificate" and fill in: | ||
|
|
||
| - **Client Certificate Path:** path to the certificate file (or to a | ||
| single file containing both the certificate and the private key). | ||
| - **Client Private Key Path:** optional, leave empty if the private key | ||
| is bundled in the certificate file. | ||
|
|
||
| To manage these paths with ``server_environment``, see | ||
| ``webservice_client_certificate_auth_server_env``. | ||
|
|
||
| Usage | ||
| ===== | ||
|
|
||
| When a call is made using the backend, the ``cert`` parameter is | ||
| automatically injected into the underlying Python ``requests`` call | ||
| based on the provided configuration: | ||
|
|
||
| - **Certificate only:** Passed as ``cert='/path/to/file'`` (a single | ||
| file containing the private key and the certificate). | ||
| - **Certificate and Key:** Passed as a tuple | ||
| ``cert=('/path/to/crt', '/path/to/key')``. | ||
|
|
||
| Warning: the private key to your local certificate must be unencrypted. | ||
| Currently, ``requests`` does not support using encrypted keys. | ||
|
|
||
| See `Requests: Client Side | ||
| Certificates <https://requests.readthedocs.io/en/latest/user/advanced/#client-side-certificates>`__ | ||
| for underlying implementation details. | ||
|
|
||
| Bug Tracker | ||
| =========== | ||
|
|
||
| Bugs are tracked on `GitHub Issues <https://github.com/OCA/web-api/issues>`_. | ||
| In case of trouble, please check there if your issue has already been reported. | ||
| If you spotted it first, help us to smash it by providing a detailed and welcomed | ||
| `feedback <https://github.com/OCA/web-api/issues/new?body=module:%20webservice_client_certificate_auth%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. | ||
|
|
||
| Do not contact contributors directly about support or help with technical issues. | ||
|
|
||
| Credits | ||
| ======= | ||
|
|
||
| Authors | ||
| ------- | ||
|
|
||
| * Camptocamp | ||
|
|
||
| Contributors | ||
| ------------ | ||
|
|
||
| - Vincent Van Rossem <vincent.vanrossem@camptocamp.com> | ||
|
|
||
| Maintainers | ||
| ----------- | ||
|
|
||
| This module is maintained by the OCA. | ||
|
|
||
| .. image:: https://odoo-community.org/logo.png | ||
| :alt: Odoo Community Association | ||
| :target: https://odoo-community.org | ||
|
|
||
| OCA, or the Odoo Community Association, is a nonprofit organization whose | ||
| mission is to support the collaborative development of Odoo features and | ||
| promote its widespread use. | ||
|
|
||
| This module is part of the `OCA/web-api <https://github.com/OCA/web-api/tree/18.0/webservice_client_certificate_auth>`_ project on GitHub. | ||
|
|
||
| You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| from . import models |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # Copyright 2026 Camptocamp SA | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| { | ||
| "name": "WebService - Client Certificate Authentication", | ||
| "version": "18.0.1.0.0", | ||
| "license": "AGPL-3", | ||
| "author": "Camptocamp, Odoo Community Association (OCA)", | ||
| "website": "https://github.com/OCA/web-api", | ||
| "depends": ["webservice_core"], | ||
| "data": [ | ||
| "views/webservice_backend.xml", | ||
| ], | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| from . import webservice_backend |
39 changes: 39 additions & 0 deletions
39
webservice_client_certificate_auth/models/webservice_backend.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # Copyright 2026 Camptocamp SA | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| from odoo import fields, models | ||
|
|
||
|
|
||
| class WebserviceBackend(models.Model): | ||
| _inherit = "webservice.backend" | ||
|
|
||
| auth_type = fields.Selection( | ||
| selection_add=[("client_certificate", "Client Certificate")], | ||
| ondelete={"client_certificate": lambda recs: recs.write({"auth_type": "none"})}, | ||
| ) | ||
| client_certificate_path = fields.Char( | ||
| auth_type="client_certificate", | ||
| ) | ||
| client_private_key_path = fields.Char() | ||
|
|
||
| def _request(self, method, url=None, url_params=None, **kwargs): | ||
| if self.auth_type == "client_certificate": | ||
| # ``requests`` ``cert`` parameter accepts: | ||
| # * A string: path to a file containing both certificate and private key | ||
| # * A tuple: ('/path/client.cert', '/path/client.key') | ||
| cert_path = self._get_cert_path() | ||
| key_path = self._get_key_path() | ||
|
|
||
| if "cert" not in kwargs and cert_path: | ||
| if key_path: | ||
| kwargs["cert"] = (cert_path, key_path) | ||
| else: | ||
| kwargs["cert"] = cert_path | ||
|
|
||
| return super()._request(method, url=url, url_params=url_params, **kwargs) | ||
|
|
||
| def _get_cert_path(self): | ||
| return self.client_certificate_path | ||
|
|
||
| def _get_key_path(self): | ||
| return self.client_private_key_path |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [build-system] | ||
| requires = ["whool"] | ||
| build-backend = "whool.buildapi" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| On the webservice backend, set the authentication type to "Client Certificate" and fill in: | ||
|
|
||
| * **Client Certificate Path:** path to the certificate file (or to a single file containing both the certificate and the private key). | ||
| * **Client Private Key Path:** optional, leave empty if the private key is bundled in the certificate file. | ||
|
|
||
| To manage these paths with `server_environment`, see `webservice_client_certificate_auth_server_env`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - Vincent Van Rossem \<<vincent.vanrossem@camptocamp.com>\> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Adds support for Client Side Certificates to the `webservice_core` module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| When a call is made using the backend, the `cert` parameter is automatically injected into the underlying Python `requests` | ||
| call based on the provided configuration: | ||
|
|
||
| * **Certificate only:** Passed as `cert='/path/to/file'` (a single file containing the private key and the certificate). | ||
| * **Certificate and Key:** Passed as a tuple `cert=('/path/to/crt', '/path/to/key')`. | ||
|
|
||
| Warning: the private key to your local certificate must be unencrypted. Currently, `requests` does not support using encrypted keys. | ||
|
|
||
| See [Requests: Client Side Certificates](https://requests.readthedocs.io/en/latest/user/advanced/#client-side-certificates) for underlying implementation details. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a small comment to explain why these values are hardcoded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thankfully I wrote it in the commit message, because I didn't remember why I hardcoded the values 😅
Comment is added