Skip to content

[18.0][REF] webservice: split core to webservice_core - #164

Merged
OCA-git-bot merged 2 commits into
OCA:18.0from
camptocamp:18-ws-split-core
Sep 23, 2026
Merged

[18.0][REF] webservice: split core to webservice_core#164
OCA-git-bot merged 2 commits into
OCA:18.0from
camptocamp:18-ws-split-core

Conversation

@simahawk

@simahawk simahawk commented Sep 15, 2026

Copy link
Copy Markdown
Contributor
  • leave component dependency and oauth implementation into webservice
  • define new handler mechanism (similar to endpoint)
  • move request handling to a mixin that can be reusable
  • add some documentation (!!!)

@OCA-git-bot

OCA-git-bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added mod:webservice Module webservice series:18.0 mod:webservice_core Module webservice_core labels Sep 15, 2026
@simahawk
simahawk force-pushed the 18-ws-split-core branch 2 times, most recently from 99b6ed2 to 9072116 Compare September 16, 2026 10:09
@simahawk
simahawk marked this pull request as ready for review September 16, 2026 10:16
Ricardoalso
Ricardoalso reviewed Sep 21, 2026
View reviewed changes

@Ricardoalso Ricardoalso left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in the overall

Some open points I found

Comment thread webservice_core/models/webservice_request_mixin.py

@Ricardoalso Ricardoalso Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like discussed, it would be great to incorporate the content_only flag mentioned in #142 into this mixin.

Keeping the request.content as the default (even if it isn't respecting the Request documentation)

All of Requests’ functionality can be accessed by these 7 methods. They all return an instance of the Response object.

https://requests.readthedocs.io/en/latest/api/#main-interface

but at least it would be configurable in the GUI and we avoid breaking things (FIX proposal done in #144)

@simahawk simahawk Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll tackle this in a second PR to ease review.

Comment thread webservice_core/models/webservice_backend.py Outdated
Comment thread webservice_core/utils.py
Comment thread webservice_core/tests/test_webservice.py
etobella
etobella approved these changes Sep 21, 2026
View reviewed changes

@etobella etobella left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Greatº

@simahawk
[ADD] website_core: split core out of webservice
da8a036 
webservice_core: improve tech_name

* go to mixin to be reusable
* auto-generate it and auto-clean it
@simahawk

simahawk commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

@Ricardoalso all comments addressed

@simahawk

simahawk commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

FTR I've bumped webservice version manually to 2.0.0

@simahawk

simahawk commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-164-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot

OCA-git-bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@simahawk The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_webservice_core-18.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading odoo_addon_webservice_core-18.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests

@simahawk

simahawk commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

@OCA/pypi-support can you pls register webservice_core on pypi? 😇

@simahawk simahawk mentioned this pull request Sep 22, 2026
Merged
@simahawk

simahawk commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-164-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit e9ed28d into OCA:18.0 Sep 23, 2026
5 of 7 checks passed
@OCA-git-bot

OCA-git-bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 9da7e37. Thanks a lot for contributing to OCA. ❤️

@Ricardoalso Ricardoalso mentioned this pull request Sep 24, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etobella etobella etobella approved these changes
+3 more reviewers
@ivantodorovich ivantodorovich ivantodorovich approved these changes
@SilvioC2C SilvioC2C SilvioC2C approved these changes
@Ricardoalso Ricardoalso Ricardoalso approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:webservice_core Module webservice_core mod:webservice Module webservice series:18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@simahawk @OCA-git-bot @ivantodorovich @etobella @SilvioC2C @Ricardoalso