-
Notifications
You must be signed in to change notification settings - Fork 1
KEH-2655 - PyJWT Migration #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
84b9c51
refactor: bring inline with KEH template and other Py packages
TotalDwarf03 7d90c9c
fix: remove old readme content
TotalDwarf03 db6eb76
fix: lint + fmt issues
TotalDwarf03 449d312
fix: Replace jwt with pyjwt to remove library conflicts
TotalDwarf03 1925b80
test: add unit tests
TotalDwarf03 812c854
refactor: split __init__.py into multiple modules
TotalDwarf03 9e91f91
docs: update
TotalDwarf03 115f346
chore: PR feedback
TotalDwarf03 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1 @@ | ||
| @TotalDwarf03 | ||
| @ONS-Innovation/keh-dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,29 @@ | ||
| ## What type of PR is this? (check all applicable) | ||
| <!-- markdownlint-disable MD041 --> | ||
| ## Overview | ||
|
|
||
| - [ ] Refactor | ||
| - [ ] Feature | ||
| - [ ] Bug Fix | ||
| - [ ] Optimization | ||
| - [ ] Documentation Update | ||
| <!-- Provide an overview of the changes in this pull request --> | ||
|
|
||
| ### What | ||
| ## Testing | ||
|
|
||
| Describe what you have changed and why. | ||
| <!-- Describe how to test the changes in this pull request --> | ||
|
|
||
| ### Testing | ||
| ## Checklist | ||
|
|
||
| Have any new tests been added as part of this issue? If not, try to explain why test coverage is not needed here. | ||
| <!-- Please check off the following items before submitting this pull request --> | ||
| <!-- If anything is not applicable, please explain why in the exemptions section --> | ||
|
|
||
| - [ ] Yes | ||
| - [ ] No | ||
| Please write a brief description of why test coverage is not necessary here. | ||
| - [ ] Not as part of this ticket. (Could be done at a later point) | ||
| - [ ] I have reviewed the changes in this pull request | ||
| - [ ] I have tested the changes locally | ||
| - [ ] I have updated/created any relevant documentation | ||
| - [ ] I have updated/created any relevant tests | ||
| - [ ] I have added any necessary labels to this pull request | ||
| - [ ] I have assigned myself to this pull request | ||
| - [ ] I have assigned the appropriate reviewers to this pull request | ||
|
|
||
| ### Documentation | ||
| ### Exemptions | ||
|
|
||
| Has any new documentation been written as part of this issue? We should try to keep documentation up to date | ||
| as new code is added, rather than leaving it for the future. | ||
| <!-- If any of the above checklist items are not applicable, please explain why here --> | ||
|
|
||
| - [ ] Yes | ||
| - [ ] No | ||
| Please write a brief description of why documentation is not necessary here. | ||
| - [ ] Not as part of this ticket. (Could be done at a later point) | ||
| ## Additional Notes | ||
|
|
||
| ### Related issues | ||
|
|
||
| Provide links to any related issues. | ||
|
|
||
| ### How to review | ||
|
|
||
| Describe the steps required to test the changes. | ||
| <!-- Add any additional notes or comments here --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| --- | ||
| name: Documentation CI | ||
| on: | ||
| push: | ||
| branches: [main] | ||
| paths: ["**/*.md"] | ||
| pull_request: | ||
| branches: [main] | ||
| paths: ["**/*.md"] | ||
| permissions: | ||
| contents: read | ||
| jobs: | ||
| lint-docs: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # V4.3.1 | ||
| with: | ||
| persist-credentials: false | ||
| - name: Set up Node.js | ||
| uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # V5 | ||
| with: | ||
| node-version: "20" | ||
| - name: Install markdownlint | ||
| run: | | ||
| npm install -g markdownlint-cli | ||
| - name: Run markdownlint | ||
| run: | | ||
| markdownlint **/*.md | ||
|
TotalDwarf03 marked this conversation as resolved.
|
||
| verify-build: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # V4.3.1 | ||
| with: | ||
| persist-credentials: false | ||
| - name: Set up Python | ||
| uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # V5.6.0 | ||
| with: | ||
| python-version: 3.x | ||
| - run: echo "cache_id=$(date --utc '+%V')" >> $GITHUB_ENV | ||
| - uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # V4.3.0 | ||
| with: | ||
| key: mkdocs-material-${{ env.cache_id }} | ||
| path: .cache | ||
| restore-keys: | | ||
| mkdocs-material- | ||
| - run: pip install poetry | ||
| - run: poetry config virtualenvs.create false | ||
| - run: poetry install --only docs | ||
| - run: mkdocs build | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| --- | ||
| name: Linting and Formatting | ||
| on: | ||
| push: | ||
| branches: [main] | ||
| paths: | ||
| - src/** | ||
| - tests/** | ||
| pull_request: | ||
| branches: [main] | ||
| paths: | ||
| - src/** | ||
| - tests/** | ||
|
TotalDwarf03 marked this conversation as resolved.
|
||
| permissions: | ||
| contents: read | ||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # V4.3.1 | ||
| with: | ||
| persist-credentials: false | ||
| - name: Install Poetry | ||
| run: | | ||
| pipx install poetry | ||
| - name: Set up Python | ||
| uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # V5.6.0 | ||
| with: | ||
| python-version-file: ".python-version" | ||
| cache: poetry | ||
| - name: Install dependencies | ||
| run: | | ||
| make install-dev | ||
| - name: Run linters | ||
| run: | | ||
| make lint | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| --- | ||
| name: Testing | ||
| on: | ||
| push: | ||
| branches: [main] | ||
| paths: | ||
| - src/** | ||
| - tests/** | ||
| pull_request: | ||
| branches: [main] | ||
| paths: | ||
| - src/** | ||
| - tests/** | ||
|
TotalDwarf03 marked this conversation as resolved.
|
||
| permissions: | ||
| contents: read | ||
| jobs: | ||
| unit-tests: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # V4.3.1 | ||
| with: | ||
| persist-credentials: false | ||
| - name: Install Poetry | ||
| run: | | ||
| pipx install poetry | ||
| - name: Set up Python | ||
| uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # V5.6.0 | ||
| with: | ||
| python-version-file: ".python-version" | ||
| cache: poetry | ||
| - name: Install dependencies | ||
| run: | | ||
| make install-dev | ||
| - name: Run tests | ||
| run: | | ||
| make test | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| --- | ||
| name: Deploy Documentation (MkDocs) | ||
| on: | ||
| push: | ||
| branches: [main] | ||
| paths: [docs/**] | ||
|
TotalDwarf03 marked this conversation as resolved.
|
||
| workflow_dispatch: | ||
| permissions: | ||
| contents: write | ||
| jobs: | ||
| deploy: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # V4.3.1 | ||
| with: | ||
| persist-credentials: true # Persist credentials since git operations are used. | ||
| - name: Configure Git Credentials | ||
| run: | | ||
| git config user.name github-actions[bot] | ||
| git config user.email 41898282+github-actions[bot]@users.noreply.github.com | ||
| - name: Set up Python | ||
| uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # V5.6.0 | ||
| with: | ||
| python-version: 3.x | ||
| - run: echo "cache_id=$(date --utc '+%V')" >> $GITHUB_ENV | ||
| - uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # V4.3.0 | ||
| with: | ||
| key: mkdocs-material-${{ env.cache_id }} | ||
| path: .cache | ||
| restore-keys: | | ||
| mkdocs-material- | ||
| - run: pip install poetry | ||
| - run: poetry config virtualenvs.create false | ||
| - run: poetry install --only docs | ||
| - run: mkdocs gh-deploy --force | ||
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.