Keh 2606 team best practice update

[stefandeissler]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

What

https://officefornationalstatistics.atlassian.net/wiki/spaces/KEH/pages/457113830/Archive+Tool+Repository+Standards+Refresh

Testing

Have any new tests been added as part of this issue? If not, try to explain why test coverage is not needed here.

• Yes
• No
  Please write a brief description of why test coverage is not necessary here.
• Not as part of this ticket. (Could be done at a later point)

Documentation

Has any new documentation been written as part of this issue? We should try to keep documentation up to date
as new code is added, rather than leaving it for the future.

• Yes
• No
  Please write a brief description of why documentation is not necessary here.
• Not as part of this ticket. (Could be done at a later point)

Related issues

Provide links to any related issues.

How to review

Describe the steps required to test the changes.

[github-actions]

✅⚠️MegaLinter analysis: Success with warnings

Descriptor	Linter	Files	Fixed	Errors	Warnings	Elapsed time
✅ ACTION	zizmor	5		0	0	3.39s
⚠️ BASH	bash-exec	5		3	0	0.01s
✅ BASH	shellcheck	5		0	0	1.86s
✅ BASH	shfmt	5		0	0	0.38s
✅ CSHARP	csharpier	1		0	0	0.39s
✅ DOCKERFILE	hadolint	1		0	0	1.61s
✅ JSON	jsonlint	1		0	0	0.05s
✅ JSON	prettier	1		0	0	0.18s
✅ JSON	v8r	1		0	0	2.76s
✅ MARKDOWN	markdownlint	11		0	0	1.39s
✅ MARKDOWN	markdown-table-formatter	11		0	0	0.34s
✅ REPOSITORY	checkov	yes		no	no	25.44s
✅ REPOSITORY	dustilock	yes		no	no	0.02s
✅ REPOSITORY	gitleaks	yes		no	no	3.96s
✅ REPOSITORY	grype	yes		no	no	49.46s
✅ REPOSITORY	kingfisher	yes		no	no	4.04s
✅ REPOSITORY	osv-scanner	yes		no	no	0.55s
✅ REPOSITORY	secretlint	yes		no	no	1.49s
✅ REPOSITORY	syft	yes		no	no	1.45s
✅ REPOSITORY	trivy	yes		no	no	13.49s
✅ REPOSITORY	trivy-sbom	yes		no	no	0.28s
✅ TERRAFORM	terraform-fmt	6		0	0	0.77s
✅ YAML	prettier	11		0	0	0.38s
✅ YAML	v8r	11		0	0	6.32s
✅ YAML	yamllint	11		0	0	0.47s

Detailed Issues

⚠️ BASH / bash-exec - 3 errors

Results of bash-exec linter (version 5.3.3)
See documentation on https://megalinter.io/9.5.0/descriptors/bash_bash_exec/
-----------------------------------------------

❌ [ERROR] concourse/scripts/assume_role.sh
    Error: File:[concourse/scripts/assume_role.sh] is not executable

✅ [SUCCESS] concourse/scripts/build_image.sh
✅ [SUCCESS] concourse/scripts/set_pipeline.sh
❌ [ERROR] concourse/scripts/terraform_infra.sh
    Error: File:[concourse/scripts/terraform_infra.sh] is not executable

❌ [ERROR] shell_scripts/md_fix.sh
    Error: File:[shell_scripts/md_fix.sh] is not executable

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

• Documentation: Custom Flavors
• Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters ACTION_ZIZMOR,BASH_EXEC,BASH_SHELLCHECK,BASH_SHFMT,CSHARP_CSHARPIER,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_DUSTILOCK,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_OSV_SCANNER,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_KINGFISHER,TERRAFORM_TERRAFORM_FMT,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

[delterr]

Looks good

[precious-onyenaucheya-ons]

Looks good to me