Skip to content

Merge critical changes from Fusion Seed repo into main - #57

Open
pzhanggit wants to merge 4 commits into
ORNL:mainfrom
pzhanggit:merge-fusiontomain-clean
Open

Merge critical changes from Fusion Seed repo into main#57
pzhanggit wants to merge 4 commits into
ORNL:mainfrom
pzhanggit:merge-fusiontomain-clean

Conversation

@pzhanggit

Copy link
Copy Markdown
Collaborator

This is part of MATEY development within the fusion seed project IGNOS (https://github.com/FusionFM/, repos currently private). Major changes include:

  • New fusion datasets: GkeyllTrajDataset, GraphXGCDataset, and SOLPSBaseDataset
  • Model changes to handle graph partition with patching simultaneously
  • Inference and visualization scripts as well as config files for fusion datasets
  • Some bug fixing changes introduced from other ongoing dev branches

@pzhanggit
pzhanggit requested a review from TsChala August 20, 2026 14:42
@pzhanggit pzhanggit self-assigned this Aug 20, 2026

@TsChala TsChala left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few minor issues here and there, but overall should be good. I remember seeing some of these changes already in the other branches.

Comment thread matey/data_utils/datasets.py Outdated
Comment thread matey/data_utils/netcdf_datasets.py Outdated
Comment thread examples/config/Demo_D3D-SOLPS.yaml Outdated
Comment thread matey/utils/visualization_loss.py Outdated
Comment thread matey/data_utils/graph_datasets.py Outdated
Comment thread examples/config/Demo_D3D-SOLPS.yaml Outdated
Comment thread matey/data_utils/utils.py Outdated
@pzhanggit

Copy link
Copy Markdown
Collaborator Author

I found a few minor issues here and there, but overall should be good. I remember seeing some of these changes already in the other branches.

Thanks! Yes, see my description in the beginning - this PR changes from other branches that have not been merged into main yet, as they were needed for bug fixing etc... Hopefully, they would make our future merging easier. The new commit should've covered all your comments.

@pzhanggit
pzhanggit requested a review from TsChala August 20, 2026 20:31

@TsChala TsChala left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one more location where the XGC reader is imported.

Comment thread matey/inference.py Outdated
@pzhanggit
pzhanggit requested a review from TsChala August 21, 2026 13:37

@TsChala TsChala left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants