Skip to content

Filter ga_standards by saved selection, with ?all=true bypass #1083

Description

@northdpole

Parent: #1079 · Splits #1043 §2 · Project: https://github.com/orgs/OWASP/projects/60

What

GET /rest/v1/ga_standards feeds Map Analysis / gap-analysis dropdowns. It is not passed through apply_user_resource_filter. Completing the profile view means:

  1. Filter ga_standards the same way as /standards when the user has a non-empty selection (keep OpenCRE; empty selection = full eligible list).
  2. Frontend must pass ?all=true wherever GA should still span all eligible standards (same pattern as ResourceSelector).

Left out of #586 on purpose so we would not silently shrink the dropdowns.

Do

  • Apply apply_user_resource_filter (or equivalent) on /rest/v1/ga_standards
  • Keep GA eligibility gating (resource_name_ga_eligible_in_db)
  • Map Analysis UI: default to filtered list when a selection exists; explicit “all eligible standards” uses ?all=true
  • Tests: logged-in filtered, ?all=true bypass, anonymous full, flags off = full

Success

A user who saved ASVS+CWE sees those (if GA-eligible) in the dropdowns by default, and can still run a comparison against the full eligible set without clearing their profile.

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Medium PriorityenhancementNew feature or requestnot ready for developmentNeeds design/agreement before implementationuntriagedNot yet triaged by maintainers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions