Add standalone JSON logging (cre_logging) - #1101
Merged
Merged
Conversation
Keep cre_logging off the Flask application package so importing a logger never loads create_app. Emit one JSON object per line with module, file, and calling method.
northdpole
requested review from
Pa04rth,
paoga87 and
robvanderveer
as code owners
September 13, 2026 12:42
4 tasks
Contributor
|
Important Review skippedToo many files! This PR contains 305 files, which is 205 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (305)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
Merging with admin bypass: Test, Lint, Frontend Lint, Librarian, Analyze (python), and both e2e jobs are green. CodeQL failed on pre-existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cre_loggingso every module canfrom cre_logging import get_loggerwithout importing Flask/application.__init__.module,file,method, andlevel.logging.basicConfig()/ unusedpprint, and send relevantprintprogress/errors through the logger. CLI machine output (print(summary.to_json())) stays on stdout.Supersedes #856 (optional JSON +
application.utils.logging_config, which still sits under the heavy application package).Test plan
python -m unittest application.tests.cre_logging_test(includes subprocess check thatimport cre_loggingdoes not loadapplicationorflask)make lint/make mypy/make testMade with Cursor